Skip to content

Update creator_type to use getMorphClass() - #34

Open
HishamM1 wants to merge 1 commit into
developmentfrom
fix-creator-type
Open

Update creator_type to use getMorphClass()#34
HishamM1 wants to merge 1 commit into
developmentfrom
fix-creator-type

Conversation

@HishamM1

@HishamM1 HishamM1 commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

Description

When creating a question cluster, question variant, interview template, or answer variant, it was expected that the creator type would match the morph type. Instead, it was returning the creator namespace as "Domain\Organization\Models\Employee" instead of simply "employee".

Ticket(s)

Browser & API Testing

Links to browser tests.

Checklist

  • merged the current development branch (before testing)

  • ran automated tests

  • checked PSR-12 coding standard and comments guide link

  • double-checked the target branch

  • code supports type deceleration PHP type delaration

If API

  • added/updated API testing endpoints and documentation

If web

  • tested all links on different screen sizes

Review/Test checklist

  • ran automated tests

  • reviewed code and documentation

  • reviewed API endpoints and documentation

  • tested all links in project-relevant browsers

  • tested all links on different screen sizes

@HishamM1
HishamM1 requested a review from aabadawy March 7, 2024 02:42
@HishamM1 HishamM1 self-assigned this Mar 7, 2024
@aabadawy

aabadawy commented Mar 7, 2024

Copy link
Copy Markdown
Contributor

BTW we need to change the way we save the creator in each table.
Let's discuss it on the next BE meeting.
@HishamM1
If u have an any ideas feel free to mention them on slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants