Update creator_type to use getMorphClass() - #34
Open
HishamM1 wants to merge 1 commit into
Open
Conversation
aabadawy
approved these changes
Mar 7, 2024
Contributor
|
BTW we need to change the way we save the creator in each table. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When creating a question cluster, question variant, interview template, or answer variant, it was expected that the creator type would match the morph type. Instead, it was returning the creator namespace as "Domain\Organization\Models\Employee" instead of simply "employee".
Ticket(s)
Browser & API Testing
Links to browser tests.
Checklist
merged the current development branch (before testing)
ran automated tests
checked PSR-12 coding standard and comments guide link
double-checked the target branch
code supports type deceleration PHP type delaration
Review/Test checklist
ran automated tests
reviewed code and documentation
reviewed API endpoints and documentation
tested all links in project-relevant browsers
tested all links on different screen sizes