Skip to content

fix: change resend config, deploy build blockers#13

Merged
lautaropaske merged 4 commits into
mainfrom
fix/deploy-build-blockers
Jul 22, 2026
Merged

fix: change resend config, deploy build blockers#13
lautaropaske merged 4 commits into
mainfrom
fix/deploy-build-blockers

Conversation

@lautaropaske

Copy link
Copy Markdown
Contributor

Summary

  • pin react and react-dom to the same exact patch version and sync the Bun and npm lockfiles so installs stop resolving a mismatched pair
  • defer Resend client creation in roast-me feedback handling so missing mail credentials return a runtime JSON error instead of crashing build-time route evaluation
  • keep this PR isolated from the /api/grade work so it can merge first and unblock deploys

Testing

  • bun install --frozen-lockfile
  • bunx tsc --noEmit
  • bun run build
  • local API smoke test for POST /roast-me/api/feedback without RESEND_KEY returning 500 {\"error\":\"Resend API key not configured\"}

Follow-up

@vercel

vercel Bot commented Apr 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
open-silver Ready Ready Preview, Comment Jul 22, 2026 7:47pm

Request Review

@lautaropaske
lautaropaske marked this pull request as ready for review July 22, 2026 12:58
@lautaropaske
lautaropaske marked this pull request as draft July 22, 2026 16:24
@lautaropaske lautaropaske changed the title Fix deploy build blockers fix: deploy build blockers Jul 22, 2026
lautaropaske and others added 2 commits July 22, 2026 15:35
Pin react and react-dom to the same exact patch version and sync both lockfiles so installs resolve a deploy-safe pair instead of drifting apart.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Move Resend client creation into the request path so missing mail credentials return a runtime JSON error instead of crashing Next during build-time route evaluation.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Centralize Resend client creation in a lazy getResend() helper that logs
the missing variable and returns null. All four email routes now reject
early with a clear 500 instead of throwing from module scope, so builds
and route evaluation never require the secret while misconfigured
environments surface an explicit error at request time.
The new Resend account verifies send.silver.dev as the sending domain,
so update all four from addresses; Resend rejects sends from unverified
domains.
@lautaropaske
lautaropaske marked this pull request as ready for review July 22, 2026 20:14
@lautaropaske
lautaropaske merged commit ee2044a into main Jul 22, 2026
2 checks passed
@lautaropaske
lautaropaske deleted the fix/deploy-build-blockers branch July 22, 2026 20:15
@lautaropaske lautaropaske changed the title fix: deploy build blockers fix: change resend config, deploy build blockers Jul 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant