Unsubscribe ImageCropper's Application.Idle handler on Dispose - #1532
Merged
Conversation
ImageCropper subscribed to the static Application.Idle event in its constructor but never unsubscribed in Dispose, so the handler could still fire after the control was disposed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Palaso Tests 4 files ±0 4 suites ±0 11m 0s ⏱️ + 1m 0s Results for commit 020c3b7. ± Comparison against base commit 2959cb9. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
imnasnainaec
marked this pull request as ready for review
July 15, 2026 21:44
hahn-kev
requested changes
Jul 16, 2026
The existing smoke test passed even without the fix. This test creates and disposes an ImageCropper, then asserts the instance is garbage collected, which only happens once Dispose unsubscribes from the static Application.Idle event. Verified to fail on the un-fixed code and pass with the fix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hahn-kev
approved these changes
Jul 17, 2026
imnasnainaec
commented
Jul 17, 2026
imnasnainaec
left a comment
imnasnainaec
left a comment
Contributor
Author
There was a problem hiding this comment.
@imnasnainaec reviewed 3 files and all commit messages, made 1 comment, resolved 1 discussion, and dismissed @hahn-kev from a discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageCropper subscribed to the static
Application.Idleevent in its constructor but never unsubscribed inDispose, so the handler could still fire after the control was disposed.Tests:
Dispose_CalledTwiceAfterSettingImage_DoesNotThrowis a smoke test, andDispose_AllowsGarbageCollectionis a regression test that asserts the control is garbage-collected after disposal — it fails without the unsubscribe fix and passes with it.Devin review: https://app.devin.ai/review/sillsdev/libpalaso/pull/1532/
This change is