Migrate LexBox.sln to LexBox.slnx - #2503
Conversation
Run `dotnet sln migrate` to convert the solution to the newer XML-based .slnx format, remove the old .sln, and update all references: - .slnf solution filters point their path at LexBox.slnx (verified filters still restore correctly against a .slnx target) - .vscode dotnet.defaultSolution, README prose, and the LcmDebugger repo-root finder in Utils.cs - dev.Dockerfile COPY globs (*.sln -> *.slnx) for consistency; these globs never matched anyway since the solution is at the repo root, outside the backend/ build context Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
📝 WalkthroughWalkthroughThe LexBox solution is migrated from ChangesSolution format migration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@backend/FwHeadless/dev.Dockerfile`:
- Line 14: The dev Dockerfiles currently copy a wildcard solution from the
build-context root, but CI uses the backend directory as context and cannot
access the repository-root solution. Update both
backend/FwHeadless/dev.Dockerfile line 14 and backend/LexBoxApi/dev.Dockerfile
line 12 to use LexBox.slnx with a repo-root build context, or explicitly make
LexBox.slnx available when the context remains backend; keep the project and
props copies aligned with the resolved solution.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 52acff32-ac10-471b-8783-aa7f9d8dbabd
📒 Files selected for processing (10)
.vscode/settings.jsonFwLiteCore.slnfFwLiteOnly.slnfLexBox.slnLexBox.slnxLexBoxOnly.slnfREADME.mdbackend/FwHeadless/dev.Dockerfilebackend/FwLite/LcmDebugger/Utils.csbackend/LexBoxApi/dev.Dockerfile
💤 Files with no reviewable changes (1)
- LexBox.sln
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
🤖 AI summary
Converts the solution from the legacy
.slnformat to the newer XML-based.slnxformat usingdotnet sln migrate, removes the oldLexBox.sln, and updates every reference found in the repo.Changed:
LexBox.slnx— new, generated bydotnet sln migrate;LexBox.slnremoved.LexBoxOnly.slnf,FwLiteOnly.slnf,FwLiteCore.slnf— filterpathnow points atLexBox.slnx..vscode/settings.json—dotnet.defaultSolution→LexBox.slnx.README.md— prose reference updated.backend/FwLite/LcmDebugger/Utils.cs— repo-root finder now probes forLexBox.slnx.backend/LexBoxApi/dev.Dockerfile,backend/FwHeadless/dev.Dockerfile—COPY *.sln→*.slnx.Reviewer notes:
.slnfsolution filters restore correctly when theirpathtargets a.slnx(SDK 10.0.302).*.slnglobs are effectively dead: the build context isbackend/but the solution lives at the repo root, so the glob never matched. Updated to*.slnxonly for consistency — nothing functional depended on them..slnffiles (not the.slndirectly), so they needed no changes.Test plan
dotnet restoresucceeds forLexBox.slnxand all three.slnffilters (exit 0).