Skip to content

Add noble packaging support in fw_icu4c_ci.yml - #24

Open
jasonleenaylor wants to merge 15 commits into
fwfrom
chore/addNobleSupport
Open

Add noble packaging support in fw_icu4c_ci.yml#24
jasonleenaylor wants to merge 15 commits into
fwfrom
chore/addNobleSupport

Conversation

@jasonleenaylor

@jasonleenaylor jasonleenaylor commented Mar 5, 2025

Copy link
Copy Markdown

This change is Reviewable

@ermshiperete ermshiperete left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .github/workflows/fw_icu4c_ci.yml Outdated
Comment thread .github/workflows/fw_icu4c_ci.yml Outdated
Comment thread .github/workflows/fw_icu4c_ci.yml Outdated
Comment thread .github/workflows/fw_icu4c_ci.yml Outdated
jasonleenaylor and others added 6 commits March 6, 2025 12:15
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
It seems that with Ubuntu 24.04 the sbuild group has a password set.
This change removes the password so that we can use the `sg sbuild`
command without providing a password.
@jasonleenaylor
jasonleenaylor force-pushed the chore/addNobleSupport branch from ec9e787 to 4293209 Compare March 7, 2025 17:53
@ermshiperete

Copy link
Copy Markdown
Member

I think sillsdev/ci-builder-scripts#7 will fix the package build failure.

hahn-kev and others added 4 commits August 3, 2026 16:44
Bump checkout, artifact, cache, and setup-msbuild to current majors and replace deprecated set-output so the noble packaging PR can run on today's runners.

Co-authored-by: Cursor <cursoragent@cursor.com>
ci-builder-scripts setup.sh returns non-zero from a set -e guarded test after installing .sbuildrc if the gnupg dir was pre-created.

Co-authored-by: Cursor <cursoragent@cursor.com>
Pin Windows builds to windows-2022 to avoid Chinese calendar test failures on Server 2025/VS2026, and build noble/jammy packages separately so setup.sh does not abort on an existing ~/.gnupg.

Co-authored-by: Cursor <cursoragent@cursor.com>
…olve.

handleComputeMonthStart already restored MONTH/IS_LEAP_MONTH but left isLeapYear clobbered, so VS2026 get() paths made month rolls use the wrong year length. Also restore windows-latest now that the root cause is fixed.

Co-authored-by: Cursor <cursoragent@cursor.com>
@hahn-kev

hahn-kev commented Aug 4, 2026

Copy link
Copy Markdown

@jasonleenaylor and @ermshiperete the build is now passing again, could we get this merged in? It's blocking #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants