Dash2 - #993
Open
shocknet-justin wants to merge 35 commits into
Open
Conversation
db interface fix
asst liab pagination +userids
merge master
Member
Author
|
@BugBot review |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
Author
|
@BugBot review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3477bd3. Configure here.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Admin/dashboard API work for LightningPub (package 0.0.33, master merged).
GetAssetsAndLiabilitiesV2,GetUsersAdminInfo,GetUserOperationsFromAdminhas_more/ cursors / offsets), clamped page limits; liquidity provider slowdowns set atimeoutflag instead of failing the whole responseuser_idon operations for admin-targeted queries (backward compatible)adminManager/serverMethods, plus batch DB ops / storage fixesexpress-wsfor regenerated Express codegen; TypeScript ~6Tests
Four new specs cover the admin surface and the storage layer it depends on:
adminUsers.spec.ts(full network)skip/takevs total)assetsAndLiabilities.spec.ts(full network)users_balancematches funded usersuser_idlimit/has_more/next_index_offsetbatchAssetLookups.spec.ts(storage-only)[]; missing ids ignored; wrong op type → no matchstorageOperators.spec.ts(storage-only)Between/In/And/Like/ILike/IsNull, OR where-arraysFindAndCount,Sum, increment/decrement, delete/remove, date round-trip, skip/takeCoverage note: A&L tests exercise the LND path thoroughly; liquidity-provider timeout flagging is implemented but not asserted in these specs. Admin specs call managers directly (not HTTP/Nostr auth middleware).
Test plan
adminUsers.spec.ts— list, pagination, admin ops, banned-user bypassassetsAndLiabilities.spec.ts— users balance, LND tracked ops, pagination, v1 compatbatchAssetLookups.spec.ts— batch owner lookups across payment/invoice/tx/rootstorageOperators.spec.ts— query operators, aggregates, tx rollback