fix: update spatial extension manifest for duckdb 1.5.4 - #344
fix: update spatial extension manifest for duckdb 1.5.4#344evan-zhang11 wants to merge 1 commit into
Conversation
DuckDB crate bumped from 1.10500.0 to 1.10504.0 in PR #340 but the spatial extension manifest was not updated, causing the CI version sync check to fail. Updated: - duckdb_crate_version: 1.10500.0 → 1.10504.0 - duckdb_core_version: 1.5.0 → 1.5.4 - All artifact URLs, SHA256 hashes, and paths for all 5 platforms
607a214 to
93264aa
Compare
CI Update — Version Sync Fixed, but DuckDB 1.5.4 Has Breaking Behavior Change✅ The spatial extension version sync check now passes with the updated manifest. ❌ However, the actual tests now reveal a breaking change in DuckDB 1.5.4 itself: ErrorRoot CauseAt
In DuckDB 1.5.4, one of these statements likely fails (possibly because the column/index already exists from a previous migration), which aborts the transaction. The next call at line 116 ( Test Results
ImpactThis affects PR #340 as well — it's not just a manifest issue but a DuckDB 1.5.4 behavioral change. RecommendationThe This needs code changes before PR #340 can merge. |
Problem
PR #340 bumps the DuckDB crate from
1.10500.0→1.10504.0(core 1.5.0 → 1.5.4), but thespatial-extension-manifest.jsonwas not updated. This causes the CICheck spatial extension version syncstep to fail.Fix
Updated
backend/extensions/spatial-extension-manifest.json:duckdb_crate_version:1.10500.0→1.10504.0duckdb_core_version:1.5.0→1.5.4duckdb_version:1.5.0→1.5.4Verification
extensions.duckdb.org/v1.5.4/and verified SHA256 checksumscheck_spatial_extension_version.shpasses locally against the updated Cargo.lockMerge Strategy
This PR targets
dependabot/cargo/cargo-minor-patch-4a9f84f695(PR #340's branch). Merge this first, then #340 will have the manifest fix included and CI should pass.