Fix SM90 MegaMoE .template disambiguation on nvcc13 - #74
Open
Helicoplacoidea wants to merge 1 commit into
Open
Conversation
…plate on nvcc13 On nvcc 13.x (EDG frontend), the chained call (*l1_topk_weights_buffer).get_data_buffer(idx).get_base_ptr<float>() fails to compile inside the deferred/dependent scope of the SM90 MegaMoE epilogue, with: error: type name is not allowed error: expected an expression because EDG parses the unqualified '<' as the less-than operator instead of the start of an explicit template-argument list. Add the standard dependent-name disambiguator `.template` to the four chained `.get_data_buffer(...).get_base_ptr<float>()` call sites in sm90_fp8_mega_moe_impl() that are reported by nvcc13 (L1655/L1666/L1824/L1827). Behavior is unchanged on nvcc <= 12 where `.template` is a no-op when not strictly required, so this is a pure compile-fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure compile-fix for SM90 FP8 MegaMoE on nvcc 13.x. Adds the standard dependent-name disambiguator
.templateto four chained…get_data_buffer(…).get_base_ptr<float>()call sites insm90_fp8_mega_moe_impl().Problem
On nvcc 13.x (EDG frontend), the chained call
(*l1_topk_weights_buffer).get_data_buffer(idx).get_base_ptr<float>()fails to compile inside the deferred/dependent scope of the SM90 MegaMoE epilogue, with:
because EDG parses the unqualified
<as the less-than operator instead of the start of an explicit template-argument list.Fix
Add the standard dependent-name disambiguator
.templateto the four chained.get_data_buffer(…).get_base_ptr<float>()call sites reported by nvcc13 (L1655 / L1666 / L1824 / L1827):Compatibility
Behavior is unchanged on nvcc ≤ 12, where
.templateis a no-op when not strictly required.Test Plan