Skip to content

mod_vpp: don't re-sample PSAMPLE when osIndex=on #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ritvikiscool9 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

mod_vpp: don't re-sample PSAMPLE when osIndex=on #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
203b5a8
mod_vpp: don't re-sample PSAMPLE when osIndex=on
ritvikiscool9 Jul 27, 2026
2a47665
Modifying the guard to allow egress packets to be sampled
ritvikiscool9 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Linux/mod_vpp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,13 @@ v */
HSP_mod_VPP *mdata = (HSP_mod_VPP *)mod->data;
HSP *sp = (HSP *)EVROOTDATA(mod);
HSPPSample *psmp = (HSPPSample *)data;
// When osIndex=on, mod_psample already emits the INGRESS flow sample in the
// Linux/SONiC namespace, so re-sampling ingress here duplicates it (the 2x).
// Egress samples, however, are produced ONLY here — mod_psample's PSAMPLE
// egress group is not enabled in SONiC-VPP — so egress must still be handled.
if(sp->vpp.osIndex && psmp->grp_no == SFLOW_VPP_PSAMPLE_GROUP_INGRESS){
return;
}
if(psmp->grp_no == SFLOW_VPP_PSAMPLE_GROUP_INGRESS
|| psmp->grp_no == SFLOW_VPP_PSAMPLE_GROUP_EGRESS) {
EVDebug(mod, 3, "Got VPP PSample");
Expand Down