Skip to content

Update phf to 0.14. Bump versions.#750

Open
xu-cheng wants to merge 2 commits into
servo:mainfrom
xu-cheng:phf
Open

Update phf to 0.14. Bump versions.#750
xu-cheng wants to merge 2 commits into
servo:mainfrom
xu-cheng:phf

Conversation

@xu-cheng

Copy link
Copy Markdown
Contributor

Also bump MSRV to 1.85 as required by phf.

Per RELEASE.md, phf updates are breaking changes. Thus, bump versions for both web_atom and html5ever.

Depends on servo/string-cache#298

Also bump MSRV to 1.85 as required by phf.

Per RELEASE.md, phf updates are breaking changes. Thus, bump versions
for both web_atom and html5ever.

Depends on servo/string-cache#298
@github-actions github-actions Bot added V-non-breaking A non-breaking change and removed V-breaking Breaking change labels Jul 2, 2026
@xu-cheng

xu-cheng commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Hi, any chance to merge this and publish a new version of html5ever? Thanks.

@nicoburns

Copy link
Copy Markdown
Contributor

@mrobinson @Loirooriol @jdm @simonwuelker How urgent are the security fixes that seem to open against this repo recently?

This PR looks good to me, but I think landing it may mean that we can't upgrade the html5ever version in Servo until such time as cssparser and Stylo are also upgraded to phf 0.14 (Stylo is easy enough as we have our own fork, but cssparser will require coordination). So I'm not sure if we want to hold off on that and put out a patch release with the fixes first?

@Loirooriol

Copy link
Copy Markdown
Contributor

Will this upgrade require change changes in cssparser? Or what's the coordination that you are concerned about?

@nicoburns

Copy link
Copy Markdown
Contributor

Will this upgrade require change changes in cssparser? Or what's the coordination that you are concerned about?

cssparser and stylo/selectors also need an phf upgrade. If we want only one version of phf in Servo, then those upgrades all need to happen in sync. So the concern is that if we land this and the phf upgrade in cssparser / Stylo is slow then that might block us upgrading html5ever in Servo until that's resolved.

@simonwuelker

simonwuelker commented Jul 7, 2026

Copy link
Copy Markdown
Member

How urgent are the security fixes that seem to open against this repo recently?

I would strongly prefer not merging changes that prevent us from using the latest version of html5ever in servo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

V-non-breaking A non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants