ci: run ci.yml on docs-only pull requests - #46
Merged
Merged
Conversation
Problem - Branch protection requires the build-and-test and coverage checks from ci.yml, but its pull_request trigger ignored docs-only paths. - Docs-only PRs therefore never reported the required checks and were permanently blocked, e.g. PR #45 needed an admin override. Implementation - Drop paths-ignore from the pull_request trigger so the required checks always report; keep it on the push trigger to avoid burning CI on docs-only pushes to main. - Add a comment recording why the filter must stay off for PRs. Tests - YAML parses cleanly; the trigger change only affects when the workflow starts, not any job logic. - This PR itself touches .github/, so the full matrix runs and the required checks must report before merge.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the structural deadlock that blocked docs-only PRs: branch protection requires the
build-and-test/coveragechecks fromci.yml, but the workflow'spull_requesttrigger ignored docs paths, so those required checks never reported and PRs like #45 needed an admin override to merge.Changes
paths-ignorefrom thepull_requesttrigger in.github/workflows/ci.yml, so required checks always report on every PR.paths-ignoreon thepushtrigger — docs-only pushes tomainstill skip the full suite.Testing
.github/, so the full matrix includingbuild-and-testandcoveragemust report green before merge. A follow-up docs-only PR can serve as the real-world confirmation.