Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions semcore/input-number/__tests__/index.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -553,4 +553,30 @@ describe('InputNumber', () => {
expect(spy).lastCalledWith('', expect.anything());
expect(spy).toBeCalledTimes(4);
});

test('Verify displaying the same negative value after backspace', async () => {
const spy = vi.fn();
const { getByTestId } = render(
<InputNumber>
<InputNumber.Value defaultValue='0' onChange={spy} data-testid='input-number-value' />
</InputNumber>,
);

await userEvent.keyboard('[Tab]');

await userEvent.keyboard('-');
expect(spy).not.toBeCalled();
expect(getByTestId('input-number-value').getAttribute('value')).toBe('-');

await userEvent.keyboard('1');
expect(spy).lastCalledWith('-1', expect.anything());

await userEvent.keyboard('[Backspace]');
expect(spy).toBeCalledTimes(1);
expect(getByTestId('input-number-value').getAttribute('value')).toBe('-');

await userEvent.keyboard('1');
expect(spy).toBeCalledTimes(1);
expect(getByTestId('input-number-value').getAttribute('value')).toBe('-1');
});
});
12 changes: 10 additions & 2 deletions semcore/input-number/src/InputNumber.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,16 @@ class Value extends Component<
const digits = /^[0-9.-]+$/.test(value);

if (digits || value === '') {
this.handlers.value(this.limitDecimals(value), event);
const newValue = this.limitDecimals(value);
this.handlers.value(newValue, event);
if (newValue === prevValue) {
const { displayValue } = this.valueParser(
newValue ?? '',
prevValue,
this.state.displayValue,
);
this.setState({ displayValue });
}
}
};

Expand Down Expand Up @@ -357,7 +366,6 @@ class Value extends Component<
['0', '1', '2', '3', '4', '5', '6', '7', '8', '9'].includes(event.key))
) {
const afterSelection = value.slice(element.selectionEnd ?? undefined);

requestAnimationFrame(() => {
const newValue = this.state.displayValue;
const index = newValue.lastIndexOf(afterSelection);
Expand Down
Loading