Skip to content

[UIK-5644][inline-input] rewrite component to NS #3086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slizhevskyv-semrush wants to merge 3 commits into
base: release/v17
Choose a base branch
from
Open

[UIK-5644][inline-input] rewrite component to NS #3086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9568426
[UIK-5644][inline-input] rewrite component to NS
slizhevskyv-semrush Jul 29, 2026
4e87cdd
[chore] update deprecation message
slizhevskyv-semrush Jul 30, 2026
9f88a9d
[UIK-5644][inline-input] rewrite component to NS
slizhevskyv-semrush Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions playground/entries/InlineInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import InlineInput from '@semcore/ui/inline-input';
import type { InlineInputProps } from '@semcore/ui/inline-input';
import type { NSInlineInput } from '@semcore/ui/inline-input';
import React from 'react';

import type { JSXProps } from '../types/JSXProps';
import type { PlaygroundEntry } from '../types/Playground';
import createGithubLink from '../utils/createGHLink';

export type InlineInputJSXProps = JSXProps<InlineInputProps>;
export type InlineInputJSXProps = JSXProps<NSInlineInput.Props>;

function getJSX({ handleControlChange, ...inlineInputProps }: InlineInputJSXProps) {
return (
Expand Down
134 changes: 39 additions & 95 deletions semcore/inline-input/src/InlineInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,90 +1,20 @@
import { Box, InvalidStateBox } from '@semcore/base-components';
import { ButtonLink } from '@semcore/button';
import type { Intergalactic } from '@semcore/core';
import { createComponent, Component, sstyled, Root, lastInteraction } from '@semcore/core';
import type { WithI18nEnhanceProps } from '@semcore/core/lib/utils/enhances/i18nEnhance';
import i18nEnhance from '@semcore/core/lib/utils/enhances/i18nEnhance';
import { hasParent } from '@semcore/core/lib/utils/hasParent';
import CheckM from '@semcore/icon/Check/m';
import CloseM from '@semcore/icon/Close/m';
import InputNumber, { type NSInputNumber } from '@semcore/input-number';
import InputNumber from '@semcore/input-number';
import Spin from '@semcore/spin';
import type { TooltipProps } from '@semcore/tooltip';
import React from 'react';

import type { InlineInputComponent } from './index.type';
import type { NSInlineInput } from './InlineInput.type';
import style from './style/inline-input.shadow.css';
import type { LocalizedMessages } from './translations/__intergalactic-dynamic-locales';
import { localizedMessages } from './translations/__intergalactic-dynamic-locales';

type OnConfirm = (
value: string,
event: React.MouseEvent | React.FocusEvent | React.KeyboardEvent,
) => void;
type OnCancel = (
prevValue: string,
event: React.MouseEvent | React.FocusEvent | React.KeyboardEvent,
) => void;
type RootAsProps = {
state?: 'normal' | 'valid' | 'invalid';
loading?: boolean;
disabled?: boolean;
onConfirm?: OnConfirm;
onCancel?: OnCancel;
value?: string;
defaultValue?: string;
autoFocus?: boolean;
placeholder?: string;
onChange?: (value: string, event: React.ChangeEvent) => void;
onBlur?: (event: React.FocusEvent) => void;
onFocus?: (event: React.FocusEvent) => void;
onBlurBehavior?: 'cancel' | 'confirm';
styles?: React.CSSProperties;
Children: React.FC;
getI18nText: (messageId: string, values?: { [key: string]: string | number }) => string;
locale?: string;
};

type AddonAsProps = {
styles?: React.CSSProperties;
Children: React.FC;
};

type ControlAsProps = {
Children: React.FC;
children: React.ReactNode;
styles?: React.CSSProperties;
title?: string;
$tooltipsProps?: TooltipProps;
loading?: boolean;
disabled?: boolean;
onCancel?: OnCancel;
value?: string;
icon?: React.FC;
getI18nText: (messageId: string, values?: { [key: string]: string | number }) => string;
};
type ConfirmControlAsProps = ControlAsProps & {
onConfirm?: OnConfirm;
onCancel?: OnCancel;
inputRef?: React.RefObject<HTMLInputElement>;
};
type CancelControlAsProps = ControlAsProps & {
onCancel?: OnCancel;
};
type NumberValueAsProps = NSInputNumber.Value.Props & {
increment?: (event: WheelEvent) => void;
decrement?: (event: WheelEvent) => void;
};
type NumberControlsAsProps = ControlAsProps & {
increment?: (event: React.SyntheticEvent) => void;
decrement?: (event: React.SyntheticEvent) => void;
};
type DefaultProps = {
state: 'normal';
onBlurBehavior: 'confirm';
i18n: LocalizedMessages;
locale: 'en';
};

const pointInsideOfRect = ({
x,
y,
Expand All @@ -98,16 +28,16 @@ const pointInsideOfRect = ({
};

class InlineInputBase extends Component<
RootAsProps,
[],
Intergalactic.InternalTypings.InferComponentProps<NSInlineInput.Component>,
typeof InlineInputBase.enhance,
{},
WithI18nEnhanceProps,
{},
DefaultProps
NSInlineInput.DefaultProps
> {
static displayName = 'InlineInput';

static enhance = [i18nEnhance(localizedMessages)];
static enhance = [i18nEnhance(localizedMessages)] as const;
static defaultProps = {
state: 'normal',
onBlurBehavior: 'confirm',
Expand Down Expand Up @@ -140,7 +70,7 @@ class InlineInputBase extends Component<
document.body.addEventListener('keydown', this.handleDocumentKeyDown);
}

componentDidUpdate(prevProps: Readonly<RootAsProps>): void {
componentDidUpdate(prevProps: typeof this.asProps): void {
if (prevProps.disabled !== this.asProps.disabled) {
this.updateInert();
}
Expand Down Expand Up @@ -308,8 +238,12 @@ class InlineInputBase extends Component<
}
}

class Value extends Component<RootAsProps, [], { value: any }> {
static defaultProps = {
class Value extends Component<
Intergalactic.InternalTypings.InferChildComponentProps<NSInlineInput.Value.Component, typeof InlineInputBase, 'Value'>,
[],
NSInlineInput.Value.Handlers
> {
static defaultProps: NSInlineInput.Value.DefaultProps = {
defaultValue: '',
};

Expand All @@ -326,12 +260,16 @@ class Value extends Component<RootAsProps, [], { value: any }> {
}
}

function Addon(props: AddonAsProps) {
function Addon(
props: Intergalactic.InternalTypings.InferChildComponentProps<NSInlineInput.Addon.Component, typeof InlineInputBase, 'Addon'>,
) {
const SAddon = Root;
return sstyled(props.styles)(<SAddon render={Box} />) as React.ReactElement;
return sstyled(props.styles)(<SAddon render={Box} />);
}

function ConfirmControl(props: ConfirmControlAsProps) {
function ConfirmControl(
props: Intergalactic.InternalTypings.InferChildComponentProps<NSInlineInput.ConfirmControl.Component, typeof InlineInputBase, 'ConfirmControl'>,
) {
const SAddon = Root;
const { Children, children: hasChildren, inputRef, onCancel } = props;
const title = props.title ?? props.getI18nText('confirm');
Expand Down Expand Up @@ -362,7 +300,7 @@ function ConfirmControl(props: ConfirmControlAsProps) {
if (props.loading) {
return sstyled(props.styles)(
<SAddon render={Box}>{hasChildren ? <Children /> : <Spin size='xs' />}</SAddon>,
) as React.ReactElement;
);
}

const sstyles = sstyled(props.styles);
Expand All @@ -376,7 +314,7 @@ function ConfirmControl(props: ConfirmControlAsProps) {
)
: (
<ButtonLink
addonLeft={(props.icon as any) ?? CheckM}
addonLeft={props.icon ?? CheckM}
use='secondary'
onClick={handleConfirm}
className={sConfirmIconStyles.className}
Expand All @@ -385,10 +323,12 @@ function ConfirmControl(props: ConfirmControlAsProps) {
/>
)}
</SAddon>,
) as React.ReactElement;
);
}

function CancelControl(props: CancelControlAsProps) {
function CancelControl(
props: Intergalactic.InternalTypings.InferChildComponentProps<NSInlineInput.CancelControl.Component, typeof InlineInputBase, 'CancelControl'>,
) {
const SAddon = Root;
const { Children, children: hasChildren } = props;
const title = props.title ?? props.getI18nText('discard');
Expand All @@ -414,7 +354,7 @@ function CancelControl(props: CancelControlAsProps) {
if (props.disabled) {
return sstyled(props.styles)(
<SAddon render={Box}>{hasChildren ? <Children /> : <CloseM />}</SAddon>,
) as React.ReactElement;
);
}

const sstyles = sstyled(props.styles);
Expand All @@ -429,29 +369,33 @@ function CancelControl(props: CancelControlAsProps) {
: (
<ButtonLink
use='secondary'
addonLeft={(props.icon as any) ?? CloseM}
addonLeft={props.icon ?? CloseM}
onClick={handleCancel}
className={sCancelIconStyles.className}
style={sCancelIconStyles.style}
aria-label={title}
/>
)}
</SAddon>,
) as React.ReactElement;
);
}

function NumberValue(props: NumberValueAsProps) {
function NumberValue(
props: Intergalactic.InternalTypings.InferChildComponentProps<NSInlineInput.NumberValue.Component, typeof InlineInputBase, 'NumberValue'>,
) {
const SValue = Root;

return sstyled(props.styles)(<SValue render={InputNumber.Value} />) as React.ReactElement;
return sstyled(props.styles)(<SValue render={InputNumber.Value} />);
};

function NumberControls(props: NumberControlsAsProps) {
function NumberControls(
props: Intergalactic.InternalTypings.InferChildComponentProps<NSInlineInput.NumberControls.Component, typeof InlineInputBase, 'NumberControls'>,
) {
const SControls = Root;

return sstyled(props.styles)(
<SControls render={InputNumber.Controls} tag={InlineInput.Addon} />,
) as React.ReactElement;
);
}

/**
Expand All @@ -460,7 +404,7 @@ function NumberControls(props: NumberControlsAsProps) {
* {@link https://developer.semrush.com/intergalactic/components/inline-input/inline-input-api/|API} | {@link https://developer.semrush.com/intergalactic/components/inline-input/inline-input-code/|Examples}
*/
const InlineInput = createComponent<
InlineInputComponent,
NSInlineInput.Component,
typeof InlineInputBase
>(InlineInputBase, {
Addon,
Expand Down
Loading
Loading