Add Semgrep SAST gate; fix crypto RNG + hygiene - #37
Merged
Conversation
…ives
- Security fix: RandSeq/RandNum (verification/captcha codes) now use crypto/rand instead of time-seeded math/rand
- Pin actions/checkout + actions/setup-go to commit SHAs in cy.yml
- Enable RDS CloudWatch log exports
- Suppress verified false positives (non-crypto MD5, json.Unmarshal into interface{}, DDL string-format); replace README example RSA key with a placeholder
- Add self-contained semgrep.yml gate (public repo; master branch); 0 findings
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| os.Exit(0) | ||
| } | ||
| md5hash := md5.Sum(masterKey) | ||
| md5hash := md5.Sum(masterKey) // nosemgrep: go.lang.security.audit.crypto.use_of_weak_crypto.use-of-md5 -- non-cryptographic checksum (data sanity / indexing), not a security hash |
| log.Printf("Master key: %x\n", masterKey) | ||
| } | ||
| md5hash := md5.Sum(masterKey) | ||
| md5hash := md5.Sum(masterKey) // nosemgrep: go.lang.security.audit.crypto.use_of_weak_crypto.use-of-md5 -- non-cryptographic checksum (data sanity / indexing), not a security hash |
| } | ||
| fmt.Printf("** recreate database: %s\n", testDBName) | ||
| _, err = db.Exec(fmt.Sprintf("drop database %s", testDBName)) | ||
| _, err = db.Exec(fmt.Sprintf("drop database %s", testDBName)) // nosemgrep: go.lang.security.audit.database.string-formatted-query.string-formatted-query -- DDL with a controlled identifier; db/table names cannot be parameterized |
| fmt.Printf("error: %s\n", err) | ||
| } | ||
| _, err = db.Exec(fmt.Sprintf("create database %s", testDBName)) | ||
| _, err = db.Exec(fmt.Sprintf("create database %s", testDBName)) // nosemgrep: go.lang.security.audit.database.string-formatted-query.string-formatted-query -- DDL with a controlled identifier; db/table names cannot be parameterized |
| } | ||
| fmt.Printf("** recreate database: %s\n", testDBName) | ||
| _, err = db.Exec(fmt.Sprintf("drop database %s", testDBName)) | ||
| _, err = db.Exec(fmt.Sprintf("drop database %s", testDBName)) // nosemgrep: go.lang.security.audit.database.string-formatted-query.string-formatted-query -- DDL with a controlled identifier; db/table names cannot be parameterized |
| bdoc["data"] = encodedStr | ||
| //it is ok to use md5 here, it is only for data sanity | ||
| md5Hash := md5.Sum([]byte(encodedStr)) | ||
| md5Hash := md5.Sum([]byte(encodedStr)) // nosemgrep: go.lang.security.audit.crypto.use_of_weak_crypto.use-of-md5 -- non-cryptographic checksum (data sanity / indexing), not a security hash |
| bdoc["data"] = encodedStr | ||
| //it is ok to use md5 here, it is only for data sanity | ||
| md5Hash := md5.Sum([]byte(encodedStr)) | ||
| md5Hash := md5.Sum([]byte(encodedStr)) // nosemgrep: go.lang.security.audit.crypto.use_of_weak_crypto.use-of-md5 -- non-cryptographic checksum (data sanity / indexing), not a security hash |
| bdoc["data"] = encodedStr | ||
| //it is ok to use md5 here, it is only for data sanity | ||
| md5Hash := md5.Sum([]byte(encodedStr)) | ||
| md5Hash := md5.Sum([]byte(encodedStr)) // nosemgrep: go.lang.security.audit.crypto.use_of_weak_crypto.use-of-md5 -- non-cryptographic checksum (data sanity / indexing), not a security hash |
| bdoc["data"] = encodedStr | ||
| //it is ok to use md5 here, it is only for data sanity | ||
| md5Hash := md5.Sum([]byte(encodedStr)) | ||
| md5Hash := md5.Sum([]byte(encodedStr)) // nosemgrep: go.lang.security.audit.crypto.use_of_weak_crypto.use-of-md5 -- non-cryptographic checksum (data sanity / indexing), not a security hash |
| bdoc["key"] = userKey | ||
| bdoc["data"] = encodedStr | ||
| md5Hash := md5.Sum([]byte(encodedStr)) | ||
| md5Hash := md5.Sum([]byte(encodedStr)) // nosemgrep: go.lang.security.audit.crypto.use_of_weak_crypto.use-of-md5 -- non-cryptographic checksum (data sanity / indexing), not a security hash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fix:
RandSeq/RandNum— which generate 6-digit verification & captcha codes — used time-seededmath/rand(predictable). Switched tocrypto/randvia asecureIntnhelper.Hygiene:
actions/checkout+actions/setup-goto commit SHAs incy.yml.terraform/aws/rds.tf).Suppressed verified false positives (with justification):
json.Unmarshalintointerface{}— safe in Go ×5fmt.Sprintfqueries (identifiers can’t be parameterized) ×4Gate: self-contained
semgrep.yml(public repo → inline;masterbranch), blocking,p/golang+ common packs. Scans to 0 findings;go buildclean.🤖 Generated with Claude Code