-
Notifications
You must be signed in to change notification settings - Fork 16
Second assignment and bonus #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Swaintek
wants to merge
7
commits into
sea-401d5-javascript:master
Choose a base branch
from
Swaintek:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a900003
passed test to return greeting string
Swaintek 09e130c
Add command line functionality, first bonus
Swaintek 4a5098b
gulp runs mocha and lint
Swaintek 0f1f909
add watch task for mocha and lint
Swaintek b5607a5
.gitignore now working
Swaintek 2c254e9
move eslint options into gulp
Swaintek 1ac8bbc
update package.json with dependencies
Swaintek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| node_modules/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| 'use strict'; | ||
|
|
||
| const greet = module.exports = function() { | ||
| return `HI ${process.argv[2] || 'Dave'}`; | ||
| }; | ||
|
|
||
| console.log(greet()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| var gulp = require ('gulp'); | ||
| var mocha = require('gulp-mocha'); | ||
| var eslint = require('gulp-eslint') | ||
|
|
||
| gulp.task('mocha', function () { | ||
| return gulp.src(['test/greet_test.js'], {read: false}) | ||
| .pipe(mocha()); | ||
| }); | ||
|
|
||
| gulp.task('lint', function () { | ||
| return gulp.src(['**/*.js', '!node_modules']) | ||
| .pipe(eslint({ | ||
| rules: { | ||
| 'no-var': 1 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I saw you getting warning for using var - good job there. You might want to add something to clean up the ES6 linter errors. |
||
| } | ||
| })) | ||
| .pipe(eslint.format()); | ||
| }); | ||
|
|
||
| gulp.task('default', ['mocha', 'lint'], function () { | ||
| gulp.watch(['test/greet_test.js'], ['mocha']); | ||
| gulp.watch(['**/*.js'], ['lint']); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "name": "greet", | ||
| "version": "1.0.0", | ||
| "description": "", | ||
| "main": "greet.js", | ||
| "directories": { | ||
| "test": "test" | ||
| }, | ||
| "dependencies": { | ||
| "chai": "^3.5.0", | ||
| "eslint": "^2.9.0", | ||
| "gulp": "^3.9.1", | ||
| "gulp-eslint": "^2.0.0", | ||
| "gulp-mocha": "^2.2.0" | ||
| }, | ||
| "devDependencies": { | ||
| "mocha": "^2.4.5" | ||
| }, | ||
| "scripts": { | ||
| "test": "mocha" | ||
| }, | ||
| "author": "", | ||
| "license": "ISC" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| 'use strict' | ||
| const expect = require('chai').expect; | ||
| const greet = require('../greet'); | ||
|
|
||
| describe('greet tests', () => { | ||
| it('should greet Dave by default', () => { | ||
| expect(greet()).to.eql('HI Dave'); | ||
| }) | ||
| it('should greet from process', () => { | ||
| let backupProcess = process.argv; | ||
| process.argv = ['node', 'test_path', 'test']; | ||
| expect(greet()).to.eql('HI test'); | ||
| process.argv = backupProcess; | ||
| }) | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add something like this to your call to eslint to fix ES lint errors:
.pipe(eslint({
parserOptions: {
"ecmaVersion": 6
}...