Skip to content

fix: _set_keyspace_for_all_pools passes only the last pool's errors to callback #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mykaul wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: _set_keyspace_for_all_pools passes only the last pool's errors to callback #915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cassandra/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3439,7 +3439,7 @@ def pool_finished_setting_keyspace(pool, host_errors):
errors[pool.host] = host_errors

if not remaining_callbacks:
callback(host_errors)
callback(errors)

for pool in tuple(self._pools.values()):
pool._set_keyspace_for_all_conns(keyspace, pool_finished_setting_keyspace)
Comment on lines 3439 to 3445

@Lorak-mmk Lorak-mmk Jun 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a regression test for that?

@mykaul mykaul Jun 30, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't test_set_keyspace_for_all_pools_reports_all_errors the test for it?

Expand Down
Loading