Skip to content

fix: build PyICU with Toolforge ICU paths#64

Merged
andrewtavis merged 8 commits into
scribe-org:mainfrom
axif0:icu
Jul 11, 2026
Merged

fix: build PyICU with Toolforge ICU paths#64
andrewtavis merged 8 commits into
scribe-org:mainfrom
axif0:icu

Conversation

@axif0

@axif0 axif0 commented Jul 10, 2026

Copy link
Copy Markdown
Member

Contributor checklist

  • This pull request is on a separate branch and not the main branch
  • I have ran the ./pre-commit executable as well as make lint and have fixed all reported issues

Description

  • Fixes Toolforge deployment by building PyICU from source. As toolforge has no pkg-config/icu-config, so PyICU cannot auto-detect ICU. Manual env vars match Toolforge.md which solves the problem.

  • Gate update-and-deploy on scribe-org/Scribe-Server so forks only run check-repository

Related issue

Closes #43

@axif0 axif0 requested review from DeleMike and andrewtavis July 10, 2026 21:38
@github-actions

Copy link
Copy Markdown

Thank you for the pull request! 💙🩵

The Scribe-Server team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Data rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions

Copy link
Copy Markdown

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the continuous integration (CI) workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis

Copy link
Copy Markdown
Member

Thanks so much for this, @axif0! Do you want to take a first look and we can try to merge it this weekend, @DeleMike?

@andrewtavis andrewtavis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: All's looking great here, @axif0! Really great to have this coming into the project. Changes make total sense. I'll bring in the minor ones still needed from #60 :)

@andrewtavis andrewtavis merged commit c194bb4 into scribe-org:main Jul 11, 2026
1 check passed
@andrewtavis andrewtavis mentioned this pull request Jul 11, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ImportError: Could not import required PyICU functionality — PyICU installs successfully but fails at runtime during scribe-data get

2 participants