Skip to content

feat(doas): new completion#766

Merged
scop merged 3 commits into
scop:mainfrom
aarchetype:doas
Jun 28, 2026
Merged

feat(doas): new completion#766
scop merged 3 commits into
scop:mainfrom
aarchetype:doas

Conversation

@aarchetype

Copy link
Copy Markdown
Contributor

Fix #505

Comment thread completions/doas Outdated
Comment thread completions/doas Outdated
@Tachi107

Tachi107 commented Apr 17, 2024 via email

Copy link
Copy Markdown

@ghost ghost mentioned this pull request Aug 31, 2025
Comment thread completions/doas Outdated
@ghost

ghost commented Sep 1, 2025

Copy link
Copy Markdown

@Duncaen

Please confirm that you have no intention in merging or supporting bash completions in opendoas. Otherwise bash-completions the project, refuses to merge the bash-completion profile for doas. It's stuck for 3 years now.

@akinomyoga

Copy link
Copy Markdown
Collaborator

In case, the upstream issue is Duncaen/OpenDoas#62. The upstream PR is Duncaen/OpenDoas#84.

@Tachi107

Tachi107 commented Sep 1, 2025

Copy link
Copy Markdown

The upstream issue and patch have been ignored for four years. I think that's enough evidence of lack of interest from upstream

@scop

scop commented Jun 27, 2026

Copy link
Copy Markdown
Owner

I agree the upstream asks have been open for more than long enough. Removed the related label, this PR and review can continue now.

@akinomyoga

akinomyoga commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

To be included in bash_completion/completions-core, we need refactorings to use API v3.

@akinomyoga

Copy link
Copy Markdown
Collaborator

I have rebased.

To be included in bash_completion/completions-core, we need refactorings to use API v3.

22ebba4

Comment thread completions-core/doas.bash Outdated

@scop scop left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Merging with a commit message tweak -- we don't actually generate completions as root, but as if we are root.

@scop
scop merged commit ad5ec9a into scop:main Jun 28, 2026
9 checks passed
@akinomyoga

akinomyoga commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Thank you!

Merging with a commit message tweak -- we don't actually generate completions as root, but as if we are root.

Ah, right. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding doas support.

4 participants