Add matching .fXX suffixes to generator.py#430
Conversation
|
Warning Review limit reached
Next review available in: 58 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. 📝 WalkthroughWalkthrough
ChangesFedora configuration mapping
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull Request validationFailed🔴 Review - Missing review from a member (1 required) Success🟢 CI - All checks have passed Triggered by Workflow Run |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@generator.py`:
- Around line 100-101: Update the relevant function’s docstring and
unmatched-suffix diagnostic to include the newly supported .f<NUM> pattern
alongside .rhelXX, .cXs, and .fedora. Keep the existing validation behavior
unchanged; only expand the documented and reported accepted suffixes.
- Around line 100-101: Update the fedora_match branch in main() to verify that
the generated Fedora config exists in mapping[version] before assigning or
returning it; return "" when the selected multispec does not contain that
config, while preserving the existing config value for supported images.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
78b0077 to
2703640
Compare
Main purpose is to enable easy distgenification of the base and core containers. Added a new statement to filename_to_distro_config()
2703640 to
0f47ef5
Compare
Main purpose is to enable easy distgenification of the base and core containers. Added a new statement to filename_to_distro_config()
Summary by CodeRabbit
*.f<NUM>format are now recognized correctly.