Skip to content

Add matching .fXX suffixes to generator.py#430

Open
pkhartsk wants to merge 1 commit into
sclorg:masterfrom
pkhartsk:add-fxx-to-generator
Open

Add matching .fXX suffixes to generator.py#430
pkhartsk wants to merge 1 commit into
sclorg:masterfrom
pkhartsk:add-fxx-to-generator

Conversation

@pkhartsk

@pkhartsk pkhartsk commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Main purpose is to enable easy distgenification of the base and core containers. Added a new statement to filename_to_distro_config()

Summary by CodeRabbit

  • Bug Fixes
    • Fedora base and core image filenames using the *.f<NUM> format are now recognized correctly.
    • These filenames are mapped to the appropriate Fedora distribution configuration for image generation.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@pkhartsk, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 58e35aac-6b40-4d76-ae1b-a713c6f1f02a

📥 Commits

Reviewing files that changed from the base of the PR and between 2703640 and 0f47ef5.

📒 Files selected for processing (1)
  • generator.py
📝 Walkthrough

Walkthrough

filename_to_distro_config() recognizes Fedora base/core image filenames ending in .f<NUM>, maps them to fedora-<NUM>-x86_64.yaml, and includes the new pattern in unknown-suffix errors.

Changes

Fedora configuration mapping

Layer / File(s) Summary
Fedora suffix resolution
generator.py
Detects .f<NUM> filenames, returns the corresponding Fedora distgen configuration, and updates the fallback error message.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: phracek, frenzymadness

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding .fXX suffix handling in generator.py.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

Pull Request validation

Failed

🔴 Review - Missing review from a member (1 required)

Success

🟢 CI - All checks have passed


Triggered by Workflow Run

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@generator.py`:
- Around line 100-101: Update the relevant function’s docstring and
unmatched-suffix diagnostic to include the newly supported .f<NUM> pattern
alongside .rhelXX, .cXs, and .fedora. Keep the existing validation behavior
unchanged; only expand the documented and reported accepted suffixes.
- Around line 100-101: Update the fedora_match branch in main() to verify that
the generated Fedora config exists in mapping[version] before assigning or
returning it; return "" when the selected multispec does not contain that
config, while preserving the existing config value for supported images.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8d85e3f1-410b-4c20-9db4-8d0ebe17e949

📥 Commits

Reviewing files that changed from the base of the PR and between 498153e and 78b0077.

📒 Files selected for processing (1)
  • generator.py

Comment thread generator.py
Main purpose is to enable easy distgenification of the
base and core containers. Added a new statement to
filename_to_distro_config()
@pkhartsk pkhartsk force-pushed the add-fxx-to-generator branch from 2703640 to 0f47ef5 Compare July 13, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant