feat(web): add navbar GitHub link and move the demo CTA to the founders - #3
Merged
Merged
Conversation
Two landing page changes. The navbar gains a GitHub link immediately left of the language switcher, pointing at `routes.external.github.repo`. It borrows the switcher's own treatment -- 15px icon, 75% opacity, the same hover pill -- so the two read as one cluster rather than a button parked next to an icon. It is icon-only, so the accessible name comes from a new `navbar.github` key; the mobile drawer gets the same pairing above the fold of its footer row. The "request a demo" button moves out of the security section and into the founder quote. Asking to talk to the founders is a natural next beat after reading what they have to say, whereas the security section is a list of claims people scan rather than a place they decide from. Both buttons anchor to `#cta-section`, so this relocates the same call to action instead of adding one -- the `cta` key moves from `ComplianceDictionary` to `FounderDictionary` along with it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Two changes to the marketing home page.
A GitHub link in the navbar. It sits immediately left of the language switcher and points at
routes.external.github.repo. It borrows the switcher's own treatment — 15px icon,strokeWidth 2.5, 75% opacity, the samehover:bg-ink/5pill — so the two read as one cluster rather than a button parked next to an icon. Because it is icon-only, the accessible name comes from a newnavbar.githubkey ("scibly auf GitHub" / "scibly on GitHub"); the mobile drawer gets the same pairing next to its switcher.The demo CTA moves from the security section to the founder quote. Asking to talk to the founders is a natural next beat after reading what they have to say, whereas the security section is a list of claims people scan rather than a place they decide from. Both buttons anchor to
#cta-section, so this relocates the existing call to action rather than adding a second one — thectakey moves fromComplianceDictionarytoFounderDictionaryalong with it, and the security header keeps its eyebrow, title, and subtitle.Notes for review
actionClass + primaryActionClassand the sameArrowRighthover nudge as the button it replaces, so nothing new enters the design language.founder.tsxstays a server component — the button anchors to the CTA section rather than opening Calendly directly, matching what the security section did.Account erstellen → scibly auf GitHub → Sprache wechseln, the founder card renders its button, and the security section now contains zero links.Checklist
pnpm checkpasses (typecheck + lint + format) — 32/32 taskspnpm test:unitpasses — 10/10 tasksapps/app/apps/webchanges, ranpnpm --filter <@scibly/app|@scibly/web> run format:check🤖 Generated with Claude Code