Skip to content

Quick fixes from the open-issue triage sweep#140

Merged
tieguy merged 1 commit into
mainfrom
claude/issue-triage-quick-fixes
Jul 11, 2026
Merged

Quick fixes from the open-issue triage sweep#140
tieguy merged 1 commit into
mainfrom
claude/issue-triage-quick-fixes

Conversation

@tieguy

@tieguy tieguy commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

Three small fixes identified while triaging every open issue against the current code (full sweep results in the session; six already-resolved issues were closed directly with evidence comments).

  • Fixes verify-page drops citations whose URL is in a no-hyphen CS1 alias (chapterurl, conferenceurl) #62sp42-parsoid: URL_PARAM_ALIASES now accepts the no-hyphen CS1 alias spellings (chapterurl, conferenceurl, contributionurl, articleurl, sectionurl, entryurl, mapurl, transcripturl). A ref carrying its source in one of those was silently dropped as a non-URL source and never verified. Pairs stay adjacent so primary-URL priority remains by level, not spelling. New fixture test push_template_sources_accepts_no_hyphen_url_alias.
  • Fixes Associate Tag filter label with its input #101sp42-app: the Tag filter's TextInput is now wrapped in the shared Field primitive (exactly like the neighboring selects), so its label is programmatically associated with the input instead of being a bare adjacent Text. The now-unused filter_label helper is removed.
  • Fixes Write down the rule for when a domain's ADRs are domain-homed vs platform-homed #127 — docs: the ADR filing rule is now written down in docs/README.md ("How ADRs and PRDs are filed") and mirrored in adding-a-domain.md: platform-homed vs domain-homed follows ADR-0013's reuse-by-design test, with the wikidata (platform-homed) and references (domain-homed) precedents as worked examples.

Also regenerates docs/platform/architecture.md — the same pre-existing drift #139 fixes; the output is identical, so the two PRs merge cleanly in either order.

Type

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Build, CI, or release
  • Security-sensitive change

Validation Required

cargo test -p sp42-parsoid                                  # 9 passed incl. the new alias test
cargo check -p sp42-app --target wasm32-unknown-unknown     # clean (-D warnings)
./scripts/check-links.sh                                    # all internal links resolve
./scripts/check-doc-consistency.sh                          # pinned lines intact
./scripts/generate-architecture-map.sh --check              # fresh after regeneration

Risk

  • Touches auth/session/cookies/CSRF
  • Touches deployment/runtime configuration
  • Touches desktop packaging
  • Touches scoring or Wikimedia action behavior
  • Needs an ADR

Notes For Reviewers

🤖 Generated with Claude Code

https://claude.ai/code/session_01FWVy56w8xjBRQKwC94Har3


Generated by Claude Code

Three small fixes identified while triaging all open issues against
the current code:

- sp42-parsoid: accept the no-hyphen CS1 URL alias spellings
  (chapterurl, conferenceurl, ...) in URL_PARAM_ALIASES so refs using
  them are verified instead of dropped as non-URL sources, with a
  fixture test. Fixes #62.
- sp42-app: wrap the Tag filter's TextInput in the shared Field
  primitive (matching the selects) so its label is programmatically
  associated with the input; drops the now-unused filter_label helper.
  Fixes #101.
- docs: write down the ADR filing rule — platform-homed vs
  domain-homed follows ADR-0013's reuse-by-design test — in
  docs/README.md and adding-a-domain.md, with the wikidata/references
  precedents as examples. Fixes #127.

Architecture map regenerated (same drift PR #139 fixes; identical
output, merges clean either order).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWVy56w8xjBRQKwC94Har3
@tieguy
tieguy requested a review from schiste as a code owner July 10, 2026 22:30
@tieguy
tieguy merged commit 1d3b121 into main Jul 11, 2026
4 checks passed
@tieguy
tieguy deleted the claude/issue-triage-quick-fixes branch July 11, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants