Quick fixes from the open-issue triage sweep#140
Merged
Conversation
Three small fixes identified while triaging all open issues against the current code: - sp42-parsoid: accept the no-hyphen CS1 URL alias spellings (chapterurl, conferenceurl, ...) in URL_PARAM_ALIASES so refs using them are verified instead of dropped as non-URL sources, with a fixture test. Fixes #62. - sp42-app: wrap the Tag filter's TextInput in the shared Field primitive (matching the selects) so its label is programmatically associated with the input; drops the now-unused filter_label helper. Fixes #101. - docs: write down the ADR filing rule — platform-homed vs domain-homed follows ADR-0013's reuse-by-design test — in docs/README.md and adding-a-domain.md, with the wikidata/references precedents as examples. Fixes #127. Architecture map regenerated (same drift PR #139 fixes; identical output, merges clean either order). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWVy56w8xjBRQKwC94Har3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small fixes identified while triaging every open issue against the current code (full sweep results in the session; six already-resolved issues were closed directly with evidence comments).
sp42-parsoid:URL_PARAM_ALIASESnow accepts the no-hyphen CS1 alias spellings (chapterurl,conferenceurl,contributionurl,articleurl,sectionurl,entryurl,mapurl,transcripturl). A ref carrying its source in one of those was silently dropped as a non-URL source and never verified. Pairs stay adjacent so primary-URL priority remains by level, not spelling. New fixture testpush_template_sources_accepts_no_hyphen_url_alias.sp42-app: the Tag filter'sTextInputis now wrapped in the sharedFieldprimitive (exactly like the neighboring selects), so its label is programmatically associated with the input instead of being a bare adjacentText. The now-unusedfilter_labelhelper is removed.docs/README.md("How ADRs and PRDs are filed") and mirrored inadding-a-domain.md: platform-homed vs domain-homed follows ADR-0013's reuse-by-design test, with the wikidata (platform-homed) and references (domain-homed) precedents as worked examples.Also regenerates
docs/platform/architecture.md— the same pre-existing drift #139 fixes; the output is identical, so the two PRs merge cleanly in either order.Type
Validation Required
Risk
Notes For Reviewers
Fieldlike its neighbors rather than a freestanding muted label.🤖 Generated with Claude Code
https://claude.ai/code/session_01FWVy56w8xjBRQKwC94Har3
Generated by Claude Code