Fix main build: add is_bare_url_ref to block_with_archive test fixture#136
Merged
Conversation
PR #109 added the field to BlockRef and updated block_with; PR #118, written before #109 merged, added block_with_archive without it. Both were green independently; their merge broke the workspace build (E0063 in sp42-mcp's lib tests), failing CI for every open PR. cargo test -p sp42-mcp: 28 passed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ATEQwdt8J9mVb94EcgRFY3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line fix for the
mainbuild breakage:crates/sp42-mcp/src/page.rs'sblock_with_archivetest helper constructs aBlockRefwithout theis_bare_url_reffield.Root cause is a semantic merge conflict between two independently-green PRs: #109 added
is_bare_url_reftoBlockRef(updating the siblingblock_withhelper), while #118 — written before #109 merged — addedblock_with_archivewithout it. Their merge fails workspace compilation (E0063insp42-mcplib tests), which is currently failing CI for every open PR (first seen on #129, a docs-only PR).Type
Validation Required
The field value (
false) matches the siblingblock_withfixture: both helpers build ordinary cite refs, not bare-URL refs.Risk
Test-fixture-only change; no production code touched.
Notes For Reviewers
After this merges, open PRs need a CI re-run (or any push) to go green — merges to
maindon't re-trigger PR checks.🤖 Generated with Claude Code
https://claude.ai/code/session_01ATEQwdt8J9mVb94EcgRFY3
Generated by Claude Code