π‘οΈ Sentinel: [security improvement] Add input length limits#19
π‘οΈ Sentinel: [security improvement] Add input length limits#19scartill wants to merge 1 commit into
Conversation
β¦exhaustion Co-authored-by: scartill <1055918+scartill@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: MEDIUM
π‘ Vulnerability: The
pyparsingimplementation is susceptible to Denial of Service (DoS) attacks via CPU exhaustion when processing extremely long strings forprincipal,resource, oractionparameters.π― Impact: An attacker could pass a massive string to the authorization check, causing the CPU to block for extended periods (e.g., >40 seconds for a 200KB string) and crashing or degrading service performance.
π§ Fix: Implemented maximum length limits on user-controlled inputs before processing: 2048 characters for
principalandresource, and 256 characters foraction. If exceeded,TagthValidationErroris raised securely.β Verification: Covered by
test_input_length_limitsunit tests insidetest/test_allowed.py.PR created automatically by Jules for task 1534768833717533960 started by @scartill