Skip to content

Update validate command - #6

Merged
rahlk merged 2 commits into
mainfrom
update-validate-command
Mar 19, 2026
Merged

Update validate command#6
rahlk merged 2 commits into
mainfrom
update-validate-command

Conversation

@bridgetmcg

Copy link
Copy Markdown
Contributor

Pull Request Summary

This PR addresses issues with the validate command which does not properly assess run.log file. Additionally it adds the --reanalyze flag to reanalyze run.log files and update the metadata.json.

Description

Change Type

Select the primary category:

  • Bug fix
  • Update existing application
  • New application
  • New benchmark layer
  • Test enhancement
  • Documentation
  • Tooling / infrastructure
  • Other:

Affected Scope

Layer(s):

  • Business Domain
  • Dependency Injection
  • Infrastructure
  • Integration
  • Persistence
  • Presentation
  • Security
  • Whole Applications
  • New layer for new contributions

Application(s):

Framework(s): (Spring / Jakarta / Quarkus / Liberty / Other)

  • Spring
  • Jakarta
  • Quarkus
  • New Layer:

Validation (Required)

  • My Validation requirements follow CONTRIBUTING.md.

Core Checks (recommended for all PRs)

  • Builds successfully
  • Docker image builds (if applicable)
  • Container starts (if applicable)
  • Smoke tests pass (if applicable)

Bug Fix / Application Update (MANDATORY)

Required for Bug fix and Update existing application

  • make test runs successfully with no errors
  • No benchmark behavior regression introduced
  • Parity with baseline preserved (or documented below)

Command executed:

make test

New Application / New Layer

Select if applicable:

  • Folder structure follows repo conventions
  • A README was added
  • A Dockerfile was included (in accordance with the CONTRIBUTING.md guidelines)
  • Smoke tests included (also in accordance with the CONTRIBUTING.md guidelines)

Test Enhancement

Select if applies to this PR

  • Added new test cases
  • Improved existing test coverage
  • Enhanced smoke tests
  • Updated test documentation
  • No test enhancements in this PR

Benchmark Integrity

Always check one:

  • No functional behavior change was introduced to unaffected applications
  • Expected behavior change have been documented
  • Infrastructure-only change

Additional Notes

Anything reviewers should know (limitations, follow-ups, special setup).

@rahlk
rahlk merged commit 9d016d1 into main Mar 19, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants