Update SQLite to version 3.53.4 - #99
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the vendored SQLite sources used by CSQLite to upstream SQLite 3.53.4, keeping the amalgamation and public header in sync and incorporating upstream fixes (notably around integer/float conversions, JSONB parsing safety, RBU/session handling, and FTS5 leaf-page handling).
Changes:
- Bump SQLite version identifiers and source IDs to 3.53.4 in both the amalgamation (
sqlite3.c) and public header (sqlite3.h). - Pull in upstream correctness/safety fixes across RBU/session, JSONB, and FTS5 code paths within the amalgamation.
- Restrict
seriesRealToI64()to file scope inseries.c(no external linkage).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Sources/CSQLite/sqlite3.c | Updates the SQLite amalgamation to 3.53.4 and brings in upstream fixes (RBU/session/FTS5/JSONB/etc.). |
| Sources/CSQLite/series.c | Makes seriesRealToI64() static (file-local) as part of the upstream update. |
| Sources/CSQLite/include/sqlite3.h | Updates the public SQLite version macros/source ID to 3.53.4 to match the amalgamation. |
Comments suppressed due to low confidence (1)
Sources/CSQLite/sqlite3.c:226945
- In rbuDeltaApply(), the copy-command delimiter check no longer reports an error when the delta ends immediately after the offset integer (lenDelta==0). The subsequent unconditional
zDelta++; lenDelta--;then advances past the end of the buffer and can lead to out-of-bounds access. The check should treat lenDelta<=0 as an error before attempting to read/skip the delimiter.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
228978
to
+228985
| pUp->zMask = (char*)&pUp[1]; | ||
| memcpy(pUp->zMask, zMask, pIter->nTblCol); | ||
| pUp->pNext = pIter->pRbuUpdate; | ||
| pIter->pRbuUpdate = pUp; | ||
|
|
||
| if( zSet ){ | ||
| const char *zPrefix = ""; | ||
|
|
||
| assert( p->rc==SQLITE_OK ); | ||
| memcpy(pUp->zMask, zMask, pIter->nTblCol); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.