Neutron vpnaas ignore ipsec site connection psk - #146
Merged
Conversation
The VPNaaS endpoints were added in ~2017 and then duplicated in 2023 when additional endpoints were added. The second set of keys in the dict will override the first set, making the first set a noop. Currently they are the same, but in the future they might not, therefore we remove them.
We don't want to log the psk of an IPsec Site Connection for operations on this object in the scope of Neutron's VPNaaS plugin.
sebageek
requested review from
Kuckkuck,
LeoZhangZXZ,
ashifnihalb,
ibakshay,
joluc,
notandy,
notque,
richardtief,
timojohlo,
trouaux and
viennaa
as code owners
July 13, 2026 14:34
rhalina
approved these changes
Jul 13, 2026
notque
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redact VPNaaS ipsec site connection being captured by the audit log.