Create agent plan content directory for backups - #3293
Open
loglapa wants to merge 1 commit into
Open
Conversation
loglapa
marked this pull request as ready for review
August 19, 2026 07:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Create
${GITLAB_SHARED_DIR}/agent_plan_contentduring data-directory initialization with the expectedgit:gitownership and0700permissions.Why
GitLab backups from 19.1 can fail with
ENOENTwhen the agent plan content directory has not been created yet. The directory is a configured backup path, but docker-gitlab does not currently initialize it.This implements the working directory-creation workaround reported in #3269 as an idempotent container lifecycle step. The related upstream GitLab bug remains open: https://gitlab.com/gitlab-org/gitlab/-/work_items/604413
Impact
Fresh and upgraded installations get the expected directory before a backup runs, avoiding a backup failure without requiring a manual workaround.
Validation
bash -n assets/runtime/functionsgit diff --checkinstall -dcommand twice in a sameersbn GitLab container and verified directory type,git:gitownership, and mode0700Fixes #3269