fix(portfolio): thread security cohort contract#193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Thread the expected GitHub security cohort count from both CLI surfaces through portfolio-truth generation and canonical receipt loading.
Why
The collector and receipt writer support a nondefault cohort size, but portfolio truth silently validated receipts against the hardcoded default. A producer using an explicit count could therefore create a valid receipt that the consumer rejected.
Review Of What Was Built
Cleanup Review
Intentionally left the divergent local catalog patch and nine historical local commits out of this PR. Their policy edits are either superseded by current main or conflict with the active Tier 0 contract.
Verification Summary
Shipped Summary
The security receipt collection contract can now use a nondefault cohort count end to end without being rejected by portfolio truth.
Next Phase
Losslessly reconcile the dirty/diverged primary checkout: preserve the old commit line under named backup refs, preserve the uncommitted patch in a named stash, and restore main as a clean tracking branch before canonical truth regeneration.
Remaining Roadmap
Regenerate canonical portfolio truth from merged main, run the seam linter, and verify PortfolioCommandCenter consumes the corrected authority.