fix: harden transport request matching against late RX#39
Open
sKuhLight wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses the cache-rebuild desync path seen in the Axis / ForgeFX traces.
The trace showed that full preset dumps can complete quickly when isolated, but normal Axis usage was producing repeated
fn=0x01/fn=0x0dcross-consumption:match=false,The existing serial and MIDI transports serialized TX, but request RX handlers still accepted every inbound frame and used quiet completion after unrelated frames. That allowed stale frames to end the wrong request early.
Changes
request()calls with amatchpredicate:Why this is the smallest robust fix
This does not assume full preset dump is slow. It prevents the observed response desynchronization at the shared transport layer for both serial and MIDI, which is the common failure surface for cache rebuild, meter polling, scene polling, status polling, and dump reads.
Notes
This is not a complete exclusive scan-mode implementation yet. The next hardening step should pause non-essential pollers during library-cache rebuild, especially meter / CPU / scene / channel edit-watch traffic. However, this patch removes the most dangerous behavior: late replies being consumed by the next request.