Skip to content

test: remove wait param in correctness test - #108

Merged
quettabit merged 1 commit into
mainfrom
wait-correctness
Aug 21, 2026
Merged

test: remove wait param in correctness test#108
quettabit merged 1 commit into
mainfrom
wait-correctness

Conversation

@sgbalogh

Copy link
Copy Markdown
Member

In the antithesis setup we run test_correctness, but it's possible for a read to hit the 60 second wait period in this environment before either reading all 1024 appended records (in the first case) or catching up (in the second).

@sgbalogh
sgbalogh marked this pull request as ready for review August 21, 2026 03:40
@sgbalogh
sgbalogh requested a review from a team as a code owner August 21, 2026 03:40
@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the correctness tests to use the read session’s default waiting behavior.

  • Removes the explicit 60-second wait from the concurrent append/read correctness test.
  • Removes the explicit 60-second wait from the caught-up-state correctness test.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains within the eligible follow-up review scope.

No blocking failure remains.

Important Files Changed

Filename Overview
tests/test_correctness.py Removes explicit read-session wait values from two asynchronous correctness tests.

Reviews (2): Last reviewed commit: "remove wait param in correctness test" | Re-trigger Greptile

@quettabit quettabit changed the title fix(test): remove wait param in correctness test test: remove wait param in correctness test Aug 21, 2026
@quettabit
quettabit merged commit a4b9b23 into main Aug 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants