test: remove wait param in correctness test - #108
Merged
Conversation
sgbalogh
marked this pull request as ready for review
August 21, 2026 03:40
Greptile SummaryThis PR updates the correctness tests to use the read session’s default waiting behavior.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains within the eligible follow-up review scope. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "remove wait param in correctness test" | Re-trigger Greptile |
wait param in correctness testwait param in correctness test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the antithesis setup we run
test_correctness, but it's possible for a read to hit the 60 secondwaitperiod in this environment before either reading all 1024 appended records (in the first case) or catching up (in the second).