test(journal): pin bare + agent-prefixed NODE_OPTIONS banner collapse (#1093) - #4979
Open
rysweet wants to merge 1 commit into
Open
test(journal): pin bare + agent-prefixed NODE_OPTIONS banner collapse (#1093)#4979rysweet wants to merge 1 commit into
rysweet wants to merge 1 commit into
Conversation
…#1093) Follow-up to PR #4977 (merged), which landed the strip_recipe_noise launcher-banner guard in plainify_pr_title but without these additional regression assertions. Adds two anti-weakening cases to plain_summary_drops_node_options_launcher_banner_title: - Bare banner with NO Conventional-Commits prefix (the first colon lives in the trailing `To change:` path, so strip_conventional_prefix is a no-op and the whole banner must still collapse via strip_recipe_noise). - Banner still wearing the recipe-runner per-agent log prefix ([HH:MM:SS] [amplihack:copilot:PID] ...), which strip_recipe_noise peels before applying the launcher-line predicate. Both must collapse to the neutral "A code change." fallback. Test-only; no production change. Pins currently-correct behaviour against regression. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
📊 Coverage Summary
Coverage data from CI run. Test files matching |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #4977 (merged), which landed the
strip_recipe_noiselauncher-banner guard in
plainify_pr_titlebut without these additionalregression assertions. This PR lands the remaining test-strengthening so the
issue #1093 anti-weakening coverage is complete in
main.Test-only — no production code change.
What changed
Adds two anti-weakening cases to
plain_summary_drops_node_options_launcher_banner_titleinsrc/journal/tests_pr_source.rs:the trailing
To change:path, sostrip_conventional_prefixis a no-op andthe whole banner must still collapse via
strip_recipe_noise.(
[HH:MM:SS] [amplihack:copilot:PID] …), whichstrip_recipe_noisepeelsbefore applying the launcher-line predicate.
Both must collapse to the neutral
"A code change."fallback, pinningcurrently-correct behaviour against regression.
Test plan
cargo test --lib journal::tests_pr_source→ 14 passed, 0 failedcargo fmt --check,cargo clippy --release -D warnings✅clippy --all-targets --all-features --locked -D warnings✅Closes #1093
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com