Offences clean - #7
Open
ryanfox1985 wants to merge 1 commit into
Open
Conversation
3 similar comments
ryanfox1985
force-pushed
the
offences-clean
branch
from
December 18, 2016 02:08
ba8d4ec to
50e9add
Compare
1 similar comment
Reduced code. Removed configurations. Fix test. More refactors. Moved load yml to configuration. Fixed slack exception. Updated readme according YAML config file.
ryanfox1985
force-pushed
the
offences-clean
branch
from
December 19, 2016 16:57
50e9add to
768e279
Compare
3 similar comments
Comment on lines
+9
to
+11
| ATTRIBUTES = %w(required_variables optional_variables environment | ||
| config_file slack_webhook_url environments).freeze | ||
| OBJECTS = %w(logger slack_notifier configurations).freeze |
There was a problem hiding this comment.
Using %i instead of %w would avoid having to later call .map(&.to_sym), for example:
ATTRIBUTES = %i(required_variables optional_variables environment
config_file slack_webhook_url environments).freeze
Comment on lines
+78
to
+81
| configuration.public_send("#{a}=", options[a]) | ||
|
|
||
| options[a.to_sym] && | ||
| configuration.public_send("#{a}=", options[a.to_sym]) |
There was a problem hiding this comment.
These might change based on previous comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved load yml to configuration.
Moved CLI code.