build(cmake): sync project VERSION to 0.7.0 - #33
Merged
Conversation
The CMake project VERSION had drifted from the git tags — it was stuck at 0.6.5 even through the v0.6.6 release, so the generated quickvizConfigVersion.cmake advertised 0.6.5. With COMPATIBILITY SameMajorVersion, that makes find_package(quickviz 0.7.0) — or even 0.6.6 — fail to resolve (requested version > reported version). Bump to 0.7.0 to match the freshly cut v0.7.0 release, and keep it in lockstep with tags going forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMake
project(quickviz VERSION …)had drifted from the git tags — stuck at 0.6.5 even through thev0.6.6release. So the generatedquickvizConfigVersion.cmakeadvertises 0.6.5, and withCOMPATIBILITY SameMajorVersion,find_package(quickviz 0.7.0)(or even0.6.6) fails to resolve — the requested version exceeds the reported one.Bumps to 0.7.0 to match the just-cut v0.7.0 release, so downstream
find_package(quickviz 0.7.0)works. Suggest keeping VERSION in lockstep with tags at each release from here.