cmake: guard the vendored stb target like googletest - #30
Merged
Conversation
Superbuilds that already provide an stb target (xmNavigation vendors the same fork) collide with an unconditional add_subdirectory; reuse the existing target when present, matching the googletest guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superbuilds that already provide an
stbtarget (xmNavigation vendors the same rxdu/stb fork) collide with the unconditionaladd_subdirectory(stb). Reuse the existing target when present — the exact pattern the googletest block below it already uses. Found while evaluating the quickviz pin bump in xmNavigation.