macOS: implement set_blur with NSVisualEffectView. kept private-apple-apis for the radius.#4632
Open
pszsh wants to merge 1 commit into
Open
macOS: implement set_blur with NSVisualEffectView. kept private-apple-apis for the radius.#4632pszsh wants to merge 1 commit into
pszsh wants to merge 1 commit into
Conversation
pszsh
force-pushed
the
blur-nsvisualeffectview
branch
from
July 17, 2026 07:06
3ac18e6 to
18d2a46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #4541 with the TODO filled in -
NSVisualEffectViewas the public default, your feature left alone for the radius.I tried to keep it simple, and answer @kchibisov's point about subviews, and follow the conventions I could see. The rest is in the changelog.
Let me know if you'd rather have it a different way. As before, happy to make changes.