Wayland, Windows, MacOS: Popup Implementation#4543
Open
Murmele wants to merge 70 commits into
Open
Conversation
madsmtm
added
DS - wayland
Murmele
commented
May 15, 2026
Murmele
commented
May 15, 2026
Murmele
marked this pull request as ready for review
May 18, 2026 08:06
Murmele
commented
May 18, 2026
ogoffart
reviewed
May 18, 2026
Murmele
commented
May 26, 2026
Murmele
force-pushed
the
popup
branch
2 times, most recently
from
June 4, 2026 12:59
facdfde to
87f6327
Compare
Reason: Because a normal window can have a parent window as well, like a Dialog
Reason: otherwise the child surface is anchored to the center
Reason: otherwise the height of the client side decoration is not considered and therefore the location is shifted
Reason: There are multiple pointers to the smithay popup. Once in state.windows and one time in the popup object it self. Just dropping the popup object releases only one pointer but we have to notify the state to release also the other
…he position Reason: Much easier in the resize handle
Reason: we have to call resize to initialize the viewport to map to correct window size
Murmele
changed the title
Reason: Because it exists only for wayland
ogoffart
reviewed
Jul 9, 2026
ogoffart
reviewed
Jul 9, 2026
Comment on lines
+120
to
+121
| anchor_rect_position.x + anchor_position.x, | ||
| anchor_rect_position.y + anchor_position.y, |
Contributor
There was a problem hiding this comment.
Why do you add this? That doesn't seem correct. The anchor should be what is specified in the anchor_rect_position verbatim, this is what the user asked for.
Edit: i've read your comment more carefully, and i think i understand it now.
I'm a bit torn whether we should document that and make sure the dev add the window decoration in account when calling set_anchor_rect.
Contributor
Author
There was a problem hiding this comment.
I think if a frame is used, the position of the frame shall be considered automatically. This is the most common usecase. If you create a custom frame (Currently not supported by winit) and you create a popup you have to consider but then you are also quite deep in the topic and you know what you are doing
ogoffart
reviewed
Jul 9, 2026
| anchor_rect_size.width.max(1), | ||
| anchor_rect_size.height.max(1), | ||
| ); | ||
| positioner.set_offset(position.x, position.y); |
Contributor
There was a problem hiding this comment.
is this behavior documented?
Reason: the positioner does not allow zero size then we get a protocol error
ogoffart
reviewed
Jul 13, 2026
| pub surface_resize_increments: Option<Size>, | ||
| /// The initial position of the window in screen coordinates. | ||
| /// | ||
| /// For popups, this position is relative to the parent window. |
Contributor
There was a problem hiding this comment.
inner our outer position?
…as normal position
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement proper decorationless popups by specifying the type of the child window with
with_type()With this PR different kind of child windows can be created
The type can be specified during creation of the Window using the window_attributes and the
with_type()function. As default a normal Window is used. IfPopupis choosen a parent must be specified, otherwise the Popup creation fails with an Error returned by thenew()function.Related issues: #403 and #4256
changelogmodule if knowledge of this change could be valuable to usersPlatforms
Wayland:
Bildschirmaufzeichnung.vom.2026-06-04.13-18-16.mp4
This work is sponsored by the NLnet foundation