Add align requirement in _mm_stream_si32 and _mm_stream_si64#2183
Open
yilin0518 wants to merge 1 commit into
Open
Add align requirement in _mm_stream_si32 and _mm_stream_si64#2183yilin0518 wants to merge 1 commit into
yilin0518 wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @davidtwco (or someone else) some time within the next two weeks. Why was this reviewer chosen?The reviewer was selected based on:
|
Author
|
The CI failed in some stages, but I think the changes I made should not produce any CI fail. I think there are some mistakes when the CI runs. Could you review about the CI result? Thank you for your help! |
Contributor
|
cc @sayantn apparently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update alignment documentation for
_mm_stream_si32and_mm_stream_si64The documentation for
_mm_stream_si32and_mm_stream_si64previously described the target as a generic memory location, but did not mention the required alignment of the memory address.These intrinsics imply that the destination memory should be naturally aligned: 4 bytes for
_mm_stream_si32and 8 bytes for_mm_stream_si64.Similar store intrinsics(_mm_stream_si128, _mm_stream_si256, _mm512_stream_si512) already document their alignment requirements, and the existing tests for these APIs also use properly aligned memory. This PR updates the documentation to make the alignment requirements explicit and consistent with the surrounding APIs.
This is a documentation-only change.