Add new tier 3 target: x86_64-unknown-none#89062
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for compiling OS kernels or other bare-metal applications for the x86-64 architecture.
Below are details on how this target meets the requirements for tier 3:
I would be willing to be a target maintainer, though I would appreciate if others volunteered to help with that as well.
Uses the same naming as the LLVM target, and the same convention as many other bare-metal targets.
I don't believe there is any ambiguity here.
I don't see any legal issues here.
I see no issues with any of the above.
Only relevant to those making approval decisions.
coreandalloccan be used.stdcannot be used as this is a bare-metal target.Use
--target=x86_64-unknown-none-elfoption to cross compile, just like any target. The target does not support running tests.I don't foresee this being a problem.
No other targets should be affected by the pull request.