Revert "Export `derive` at `core::derive` and `std::derive`" by fee1-dead · Pull Request #159877 · rust-lang/rust

fee1-dead · 2026-07-25T02:43:05Z

This reverts commit fec0998.

Temporarily addresses #159856 until we get the stability attribute to actually work...

This reverts commit fec0998.

rustbot · 2026-07-25T02:43:10Z

rustbot has assigned @clarfonthey.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: libs
libs expanded to 12 candidates
Random selection from 6 candidates

fee1-dead · 2026-07-25T02:43:31Z

r? jhpratt

jhpratt · 2026-07-25T02:44:04Z

@bors r+ rollup

rust-bors · 2026-07-25T02:44:08Z

📌 Commit c659cbd has been approved by jhpratt

It is now in the queue for this repository.

Revert "Export `derive` at `core::derive` and `std::derive`" This reverts commit fec0998. Temporarily addresses rust-lang#159856 until we get the stability attribute to actually work...

Rollup of 20 pull requests Successful merges: - #138618 (Support using const pointers in asm `const` operand) - #157962 (Lower paths to functions in const args as ConstKind::Error) - #158404 (trait_solver: normalize next-gen region constraints) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159738 (implement `CovariantUnsafeCell`) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159676 (Update wasm-component-ld to 0.5.27) - #159730 (allow accessing the contents of UnsafeCell without going through get) - #159809 (Avoid `#[target_features]`) - #159826 (Remove redundant `#[rustc_paren_sugar]` feature gate) - #159853 (Updated expect messages for `CString` struct and method documentation) - #159877 (Revert "Export `derive` at `core::derive` and `std::derive`")

theemathas · 2026-07-25T12:10:48Z

Surely this needs a crater run?

theemathas · 2026-07-25T12:15:36Z

@bors try

Revert "Export `derive` at `core::derive` and `std::derive`"

rust-bors · 2026-07-25T12:19:16Z

💔 Test for 18e53da failed: CI

theemathas · 2026-07-25T12:21:57Z

GitHub Actions has encountered an internal error when running your job.

wut

@bors try

Revert "Export `derive` at `core::derive` and `std::derive`"

rust-bors · 2026-07-25T12:24:53Z

💔 Test for fce1fe0 failed: CI

theemathas · 2026-07-25T12:44:17Z

Github actions is down: https://www.githubstatus.com/incidents/pz7g535gbs6p

Rollup of 20 pull requests Successful merges: - #138618 (Support using const pointers in asm `const` operand) - #157962 (Lower paths to functions in const args as ConstKind::Error) - #158404 (trait_solver: normalize next-gen region constraints) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159738 (implement `CovariantUnsafeCell`) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159676 (Update wasm-component-ld to 0.5.27) - #159730 (allow accessing the contents of UnsafeCell without going through get) - #159809 (Avoid `#[target_features]`) - #159826 (Remove redundant `#[rustc_paren_sugar]` feature gate) - #159853 (Updated expect messages for `CString` struct and method documentation) - #159877 (Revert "Export `derive` at `core::derive` and `std::derive`")

theemathas · 2026-07-25T14:22:24Z

@bors try

Revert "Export `derive` at `core::derive` and `std::derive`"

Revert "Export `derive` at `core::derive` and `std::derive`" This reverts commit fec0998. Temporarily addresses rust-lang#159856 until we get the stability attribute to actually work...

Rollup of 23 pull requests Successful merges: - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159738 (implement `CovariantUnsafeCell`) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159204 (Add support to caller_location to rustc_public) - #159411 ([rustdoc] Correctly handle output options with --show-coverage) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159676 (Update wasm-component-ld to 0.5.27) - #159730 (allow accessing the contents of UnsafeCell without going through get) - #159809 (Avoid `#[target_features]`) - #159810 (Add tuple never coercion collection regression test) - #159826 (Remove redundant `#[rustc_paren_sugar]` feature gate) - #159853 (Updated expect messages for `CString` struct and method documentation) - #159877 (Revert "Export `derive` at `core::derive` and `std::derive`") - #159878 (bootstrap: Remove obsolete option `build.compiletest-use-stage0-libtest`) - #159882 (Update expect messages in library/alloc/boxed.rs and library/alloc/string.rs to follow the style guide) - #159891 (Split multiline derives into std/rustc macros) - #159895 (rustc-dev-guide subtree update)

theemathas · 2026-07-25T14:25:59Z

Until crater is done,

@bors r-

rust-bors · 2026-07-25T14:26:05Z

This pull request was unapproved.

This PR was contained in the following rollups:

Rollup of 20 pull requests #159888 was unapproved
Rollup of 23 pull requests #159903 was unapproved

View changes since this unapproval

rust-bors · 2026-07-25T16:27:50Z

☀️ Try build successful (CI)
Build commit: 011c518 (011c518242557d21690f7936b5812318dc2fec47)
Base parent: da86f4d (da86f4d0726be475afbbffe40cb2f65741c51ad3)

theemathas · 2026-07-25T16:31:17Z

@craterbot check p=2

craterbot · 2026-07-25T16:31:46Z

👌 Experiment pr-159877 created and queued.
🤖 Automatically detected try build 011c518
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

fee1-dead · 2026-07-25T20:21:30Z

I'm not sure if this needs a crater run. In any case we still need to revert it because it is wrongly stabilized.

craterbot · 2026-07-25T21:25:25Z

🚧 Experiment pr-159877 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

nia-e · 2026-07-26T15:34:49Z

cc @rust-lang/libs-api - i'd be inclined to just r+ this regardless of breakage since the stabilisation was unintentional, but clearly there's disagreement on this point. do we need to fcp this?

theemathas · 2026-07-26T15:42:58Z

@nia-e If you want to just merge this, I suppose that's fine with me.

jhpratt · 2026-07-26T20:57:55Z

imo the crater run should be advisory — let people know that they're depending on something unintentionally. The result shouldn't change the fact that this PR should be merged.

nia-e · 2026-07-26T21:05:14Z

the alternative is we FCP-stabilise core::derive retroactively, which is also possible ^^

jhpratt · 2026-07-26T21:08:21Z

True; I'm not opposed to that. There is literally nothing that could change or be unresolved given that it's only a re-export.

Revert "Export derive at core::derive and std::derive"

c659cbd

This reverts commit fec0998.

rustbot assigned clarfonthey Jul 25, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 25, 2026

rustbot assigned jhpratt and unassigned clarfonthey Jul 25, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2026

jhpratt mentioned this pull request Jul 25, 2026

Rollup of 19 pull requests #159879

Closed

jhpratt mentioned this pull request Jul 25, 2026

Rollup of 20 pull requests #159888

Closed

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 25, 2026

Auto merge of #159877 - fee1-dead-contrib:rev, r=<try>

18e53da

Revert "Export `derive` at `core::derive` and `std::derive`"

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 25, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 25, 2026

Auto merge of #159877 - fee1-dead-contrib:rev, r=<try>

fce1fe0

Revert "Export `derive` at `core::derive` and `std::derive`"

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 25, 2026

Auto merge of #159877 - fee1-dead-contrib:rev, r=<try>

011c518

Revert "Export `derive` at `core::derive` and `std::derive`"

GuillaumeGomez mentioned this pull request Jul 25, 2026

Rollup of 23 pull requests #159903

Closed

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 25, 2026

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 25, 2026

nia-e added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Jul 26, 2026

theemathas added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 26, 2026

rustbot mentioned this pull request Jul 26, 2026

Tracking issue for release notes of #159877: Revert "Export derive at core::derive and std::derive" #159970

Open

Uh oh!

Uh oh!

Conversation

fee1-dead commented Jul 25, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 25, 2026

Uh oh!

fee1-dead commented Jul 25, 2026

Uh oh!

jhpratt commented Jul 25, 2026

Uh oh!

rust-bors Bot commented Jul 25, 2026

Uh oh!

theemathas commented Jul 25, 2026

Uh oh!

theemathas commented Jul 25, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 25, 2026

Uh oh!

theemathas commented Jul 25, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 25, 2026

Uh oh!

theemathas commented Jul 25, 2026

Uh oh!

theemathas commented Jul 25, 2026

Uh oh!

This comment has been minimized.

theemathas commented Jul 25, 2026

Uh oh!

rust-bors Bot commented Jul 25, 2026

Uh oh!

rust-bors Bot commented Jul 25, 2026

Uh oh!

theemathas commented Jul 25, 2026

Uh oh!

craterbot commented Jul 25, 2026

Uh oh!

fee1-dead commented Jul 25, 2026

Uh oh!

craterbot commented Jul 25, 2026

Uh oh!

nia-e commented Jul 26, 2026

Uh oh!

theemathas commented Jul 26, 2026

Uh oh!

jhpratt commented Jul 26, 2026

Uh oh!

nia-e commented Jul 26, 2026

Uh oh!

jhpratt commented Jul 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

fee1-dead commented Jul 25, 2026 •

edited by rustbot

Loading