reuse regular exported_non_generic_symbols logic in Miri by RalfJung · Pull Request #159740 · rust-lang/rust

RalfJung · 2026-07-22T20:20:58Z

This is some gnarly code we have duplicated in Miri, let's try to reuse the version from rustc.

rustbot · 2026-07-22T20:21:01Z

miri is developed in its own repository. If the Miri part of this change can be broken out, consider making this change to rust-lang/miri instead. However, if Miri needs adjusting for rustc changes, just ignore this message.

cc @rust-lang/miri

also add a test for cross-crate static initializers

RalfJung · 2026-07-23T07:28:17Z

I pushed and the changes are not showing up... github is being github again...

It says changes will "appear soon" but in my experience that never happens.
EDIT: Looks like it did happen this time.

bjorn3

r=me with CI green

View changes since this review

RalfJung · 2026-07-23T19:32:43Z

@bors r=bjorn3

rust-bors · 2026-07-23T19:32:47Z

📌 Commit 7395449 has been approved by bjorn3

It is now in the queue for this repository.

@bjorn3

…ls, r=bjorn3 reuse regular exported_non_generic_symbols logic in Miri This is some gnarly code we have duplicated in Miri, let's try to reuse the version from rustc. r? @bjorn3

RalfJung · 2026-07-24T10:11:53Z

@bors r=bjorn3

rust-bors · 2026-07-24T10:11:56Z

📌 Commit f8711a1 has been approved by bjorn3

It is now in the queue for this repository.

@bjorn3

…ls, r=bjorn3 reuse regular exported_non_generic_symbols logic in Miri This is some gnarly code we have duplicated in Miri, let's try to reuse the version from rustc. r? @bjorn3

rust-bors · 2026-07-24T10:24:23Z

⌛ Testing commit f8711a1 with merge d07b360...

Workflow: https://github.com/rust-lang/rust/actions/runs/30086053299

@bjorn3

reuse regular exported_non_generic_symbols logic in Miri This is some gnarly code we have duplicated in Miri, let's try to reuse the version from rustc. r? @bjorn3

jhpratt · 2026-07-24T10:25:39Z

@bors yield to rollup

rust-bors · 2026-07-24T10:25:42Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/30086053299

The next pull request likely to be tested is #159827.

Rollup of 3 pull requests Successful merges: - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159809 (Avoid `#[target_features]`)

@bjorn3

…ls, r=bjorn3 reuse regular exported_non_generic_symbols logic in Miri This is some gnarly code we have duplicated in Miri, let's try to reuse the version from rustc. r? @bjorn3

@bjorn3

…ls, r=bjorn3 reuse regular exported_non_generic_symbols logic in Miri This is some gnarly code we have duplicated in Miri, let's try to reuse the version from rustc. r? @bjorn3

Rollup of 17 pull requests Successful merges: - #158168 (Added implementation on `set_permissions_nofollow` for all primary platforms) - #138618 (Support using const pointers in asm `const` operand) - #157962 (Function item should not be used as const arg) - #158404 (trait_solver: normalize next-gen region constraints) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159411 ([rustdoc] Correctly handle output options with --show-coverage) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159809 (Avoid `#[target_features]`) - #159826 (Remove redundant `#[rustc_paren_sugar]` feature gate)

@bjorn3

…ls, r=bjorn3 reuse regular exported_non_generic_symbols logic in Miri This is some gnarly code we have duplicated in Miri, let's try to reuse the version from rustc. r? @bjorn3

Rollup of 16 pull requests Successful merges: - #138618 (Support using const pointers in asm `const` operand) - #157962 (Function item should not be used as const arg) - #158404 (trait_solver: normalize next-gen region constraints) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159411 ([rustdoc] Correctly handle output options with --show-coverage) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159809 (Avoid `#[target_features]`) - #159826 (Remove redundant `#[rustc_paren_sugar]` feature gate)

@bjorn3

…ls, r=bjorn3 reuse regular exported_non_generic_symbols logic in Miri This is some gnarly code we have duplicated in Miri, let's try to reuse the version from rustc. r? @bjorn3

@bjorn3

…ls, r=bjorn3 reuse regular exported_non_generic_symbols logic in Miri This is some gnarly code we have duplicated in Miri, let's try to reuse the version from rustc. r? @bjorn3

Rollup of 20 pull requests Successful merges: - #138618 (Support using const pointers in asm `const` operand) - #157962 (Lower paths to functions in const args as ConstKind::Error) - #158404 (trait_solver: normalize next-gen region constraints) - #158709 (rustdoc: warn on improperly interleaved HTML/MD) - #159720 (document #[global_allocator] constraints) - #159732 (optimization: don't look for diagnostic/canonical items without rustc_attrs enabled) - #159738 (implement `CovariantUnsafeCell`) - #159740 (reuse regular exported_non_generic_symbols logic in Miri) - #159780 (check `extern "custom"` function pointers) - #159786 (rustdoc-js: ignore editor temp files in test folder discovery) - #159819 (std::sync::poison: disable auto_cfg on PoisonError::new) - #155388 (stepping into where-clauses during normalization may be productive) - #155914 (when bailing on ambiguity, don't force other results to ambig) - #159439 (Fix(lib/fs/win): Fall back on Win32 delete for `Dir::remove_file`) - #159676 (Update wasm-component-ld to 0.5.27) - #159730 (allow accessing the contents of UnsafeCell without going through get) - #159809 (Avoid `#[target_features]`) - #159826 (Remove redundant `#[rustc_paren_sugar]` feature gate) - #159853 (Updated expect messages for `CString` struct and method documentation) - #159877 (Revert "Export `derive` at `core::derive` and `std::derive`")

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 22, 2026

rustbot assigned bjorn3 Jul 22, 2026

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 22, 2026

RalfJung force-pushed the miri-dedup-exported-symbols branch 3 times, most recently from e16cbd9 to 69ee67d Compare July 22, 2026 20:34

bjorn3 reviewed Jul 22, 2026

View reviewed changes

Comment thread src/tools/miri/src/bin/miri.rs

bjorn3 reviewed Jul 22, 2026

View reviewed changes

Comment thread src/tools/miri/src/helpers.rs Outdated

This comment has been minimized.

Sign in to view

x test cargo-miri: run all subcrate tests as well

e3712ee

also add a test for cross-crate static initializers

RalfJung force-pushed the miri-dedup-exported-symbols branch from 69ee67d to 026f239 Compare July 23, 2026 07:07

RalfJung force-pushed the miri-dedup-exported-symbols branch from 026f239 to b5cd32c Compare July 23, 2026 07:44

RalfJung commented Jul 23, 2026

View reviewed changes

Comment thread compiler/rustc_passes/src/reachable.rs Outdated

RalfJung commented Jul 23, 2026

View reviewed changes

Comment thread src/tools/miri/src/shims/foreign_items.rs

RalfJung force-pushed the miri-dedup-exported-symbols branch 2 times, most recently from 64ac2e0 to ab5dcb1 Compare July 23, 2026 16:31

bjorn3 reviewed Jul 23, 2026

View reviewed changes

Comment thread src/tools/miri/src/bin/miri.rs

RalfJung force-pushed the miri-dedup-exported-symbols branch 2 times, most recently from 410470a to 7395449 Compare July 23, 2026 16:42

bjorn3 approved these changes Jul 23, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2026

jhpratt mentioned this pull request Jul 23, 2026

Rollup of 11 pull requests #159803

Closed

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 24, 2026

RalfJung force-pushed the miri-dedup-exported-symbols branch from d69d892 to 0bf2940 Compare July 24, 2026 06:52

bjorn3 reviewed Jul 24, 2026

View reviewed changes

Comment thread src/tools/miri/src/helpers.rs Outdated

bjorn3 approved these changes Jul 24, 2026

View reviewed changes

reuse regular exported_non_generic_symbols logic in Miri

f8711a1

RalfJung force-pushed the miri-dedup-exported-symbols branch from 0bf2940 to f8711a1 Compare July 24, 2026 10:11

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2026

jhpratt mentioned this pull request Jul 24, 2026

Rollup of 3 pull requests #159827

Closed

jhpratt mentioned this pull request Jul 24, 2026

Rollup of 18 pull requests #159871

Closed

jhpratt mentioned this pull request Jul 24, 2026

Rollup of 17 pull requests #159872

Closed

jhpratt mentioned this pull request Jul 25, 2026

Rollup of 16 pull requests #159876

Closed

jhpratt mentioned this pull request Jul 25, 2026

Rollup of 19 pull requests #159879

Closed

jhpratt mentioned this pull request Jul 25, 2026

Rollup of 20 pull requests #159888

Open

Uh oh!

Uh oh!

Conversation

RalfJung commented Jul 22, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 22, 2026

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

RalfJung commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bjorn3 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RalfJung commented Jul 23, 2026

Uh oh!

rust-bors Bot commented Jul 23, 2026

Uh oh!

Uh oh!

RalfJung commented Jul 24, 2026

Uh oh!

rust-bors Bot commented Jul 24, 2026

Uh oh!

rust-bors Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Jul 24, 2026

Uh oh!

rust-bors Bot commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RalfJung commented Jul 22, 2026 •

edited by rustbot

Loading

RalfJung commented Jul 23, 2026 •

edited

Loading

bjorn3 left a comment •

edited by rustbot

Loading

rust-bors Bot commented Jul 24, 2026 •

edited

Loading