optimization: don't look for diagnostic/canonical items without rustc_attrs enabled by mejrs · Pull Request #159732 · rust-lang/rust

mejrs · 2026-07-22T17:11:08Z

No description provided.

…_attrs enabled

mejrs · 2026-07-22T17:11:23Z

optimization: don't look for diagnostic/canonical items without rustc_attrs enabled

rust-bors · 2026-07-22T19:20:04Z

☀️ Try build successful (CI)
Build commit: a7e10cb (a7e10cb790e92286329e5cdecbeacfd62d6d09f7)
Base parent: c188565 (c188565812a9b414ddf02f3c7d89e84f1ba53f7d)

rust-timer · 2026-07-22T20:09:53Z

Finished benchmarking commit (a7e10cb): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	4
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.2%, 3.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 489.502s -> 488.835s (-0.14%)
Artifact size: 387.76 MiB -> 387.83 MiB (0.02%)

mejrs · 2026-07-22T20:13:36Z

Looks like this somewhat undid the (small) regression in #159344 (comment) cc @Urgau

r? @nnethercote

Do you think this is worthwhile?

nnethercote

Looks like this somewhat undid the (small) regression in #159344 (comment) cc @Urgau

That PR slightly regressed large-workspace and externs. This PR slightly improves unused-warnings, which is a stress test with a bazillion warnings that is not representative of real-world code. Having said that, this change is trivial, so it's not like we're paying any cost. I'll let you decide if you want to merge it.

View changes since this review

nnethercote · 2026-07-23T03:38:45Z

@bors delegate=mejrs

rust-bors · 2026-07-23T03:38:48Z

✌️ @mejrs, you can now approve this pull request!

If @nnethercote told you to "r=me" after making some further change, then please make that change and post @bors r=nnethercote.

View changes since this delegation.

mejrs · 2026-07-24T06:51:51Z

let's do it

@bors r=nnethercote

rust-bors · 2026-07-24T06:51:54Z

📌 Commit aabf824 has been approved by nnethercote

It is now in the queue for this repository.

optimization: don't look for diagnostic/canonical items without rustc_attrs enabled

rust-bors · 2026-07-24T09:58:56Z

💔 Test for 742eacd failed: CI. Failed job:

auto - dist-various-1 (web logs, enhanced plaintext logs)

jhpratt · 2026-07-24T10:30:42Z

@bors retry

rust-log-analyzer · 2026-07-24T10:46:28Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#29 loading layer 8a50b5f1ebd4 625.46MB / 625.46MB 33.3s done
#29 loading layer d4d73977ead7 351B / 351B 22.6s done
#29 loading layer ae4e189d5071 624.93MB / 624.93MB 22.6s done
#29 loading layer 1ce6387464db 282B / 282B 12.3s done
#29 ERROR: write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device

#27 exporting to docker image format
#27 sending tarball 76.2s done
#27 ERROR: rpc error: code = Unknown desc = write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device
------
 > exporting to docker image format:
------
------
 > importing to docker:
------
ERROR: failed to build: failed to solve: rpc error: code = Unknown desc = write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device
Command failed. Attempt 2/5:
#0 building with "focused_yalow" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 7.17kB done
---
#27 loading layer 8a50b5f1ebd4 625.46MB / 625.46MB 32.5s done
#27 loading layer d4d73977ead7 351B / 351B 22.0s done
#27 loading layer ae4e189d5071 624.93MB / 624.93MB 21.9s done
#27 loading layer 1ce6387464db 282B / 282B 11.9s done
#27 ERROR: write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device

#26 exporting to docker image format
#26 sending tarball 75.2s done
#26 ERROR: rpc error: code = Unknown desc = write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device
------
 > exporting to docker image format:
------
------
 > importing to docker:
------
ERROR: failed to build: failed to solve: rpc error: code = Unknown desc = write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device
Command failed. Attempt 3/5:
#0 building with "focused_yalow" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 DONE 0.0s
---
#27 loading layer 8a50b5f1ebd4 625.46MB / 625.46MB 32.9s done
#27 loading layer d4d73977ead7 351B / 351B 22.3s done
#27 loading layer ae4e189d5071 624.93MB / 624.93MB 22.3s done
#27 loading layer 1ce6387464db 282B / 282B 12.2s done
#27 ERROR: write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device

#26 exporting to docker image format
#26 sending tarball 75.0s done
#26 ERROR: rpc error: code = Unknown desc = write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device
------
 > exporting to docker image format:
------
------
 > importing to docker:
------
ERROR: failed to build: failed to solve: rpc error: code = Unknown desc = write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device
Command failed. Attempt 4/5:
#0 building with "focused_yalow" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 7.17kB done
---
#27 loading layer 8a50b5f1ebd4 625.46MB / 625.46MB 32.8s done
#27 loading layer d4d73977ead7 351B / 351B 22.2s done
#27 loading layer ae4e189d5071 624.93MB / 624.93MB 22.2s done
#27 loading layer 1ce6387464db 282B / 282B 12.2s done
#27 ERROR: write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device

#26 exporting to docker image format
#26 sending tarball 76.1s done
#26 ERROR: rpc error: code = Unknown desc = write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device
------
 > exporting to docker image format:
------
------
 > importing to docker:
------
ERROR: failed to build: failed to solve: rpc error: code = Unknown desc = write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device
Command failed. Attempt 5/5:
#0 building with "focused_yalow" instance using docker-container driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 7.17kB done
---
#28 loading layer 8a50b5f1ebd4 625.46MB / 625.46MB 32.6s done
#28 loading layer d4d73977ead7 351B / 351B 22.1s done
#28 loading layer ae4e189d5071 624.93MB / 624.93MB 22.1s done
#28 loading layer 1ce6387464db 282B / 282B 12.1s done
#28 ERROR: write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device

#27 exporting to docker image format
#27 sending tarball 77.0s done
#27 ERROR: rpc error: code = Unknown desc = write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device
------
 > exporting to docker image format:
------
------
 > importing to docker:
------
ERROR: failed to build: failed to solve: rpc error: code = Unknown desc = write /build/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libllvmlibc-mt.a: no space left on device
The command has failed after 5 attempts.
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h

optimization: don't look for diagnostic/canonical items without rustc…

aabf824

…_attrs enabled

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 22, 2026

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 22, 2026

Auto merge of #159732 - mejrs:attribute_crawler, r=<try>

a7e10cb

optimization: don't look for diagnostic/canonical items without rustc_attrs enabled

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2026

rustbot assigned nnethercote Jul 22, 2026

mejrs marked this pull request as ready for review July 22, 2026 20:13

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 22, 2026

nnethercote approved these changes Jul 23, 2026

View reviewed changes

nnethercote added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 23, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 24, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 24, 2026

Auto merge of #159732 - mejrs:attribute_crawler, r=nnethercote

742eacd

optimization: don't look for diagnostic/canonical items without rustc_attrs enabled

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 24, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 24, 2026

Uh oh!

Uh oh!

Conversation

mejrs commented Jul 22, 2026

Uh oh!

mejrs commented Jul 22, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jul 22, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jul 22, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

mejrs commented Jul 22, 2026

Uh oh!

nnethercote left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nnethercote commented Jul 23, 2026

Uh oh!

rust-bors Bot commented Jul 23, 2026

Uh oh!

mejrs commented Jul 24, 2026

Uh oh!

rust-bors Bot commented Jul 24, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 24, 2026

Uh oh!

jhpratt commented Jul 24, 2026

Uh oh!

rust-log-analyzer commented Jul 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nnethercote left a comment •

edited by rustbot

Loading