Implement opt-in debugger discovery for GDB and LLDB in bootstrap#159455
Conversation
|
This PR modifies If appropriate, please update This PR modifies If appropriate, please update |
|
|
c870dc1 to
2ad24e5
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Thanks, only one nit.
NB: rust-lang/compiler-team#1012 has now been accepted.
(we still have to fix this for CI, didn't mean for this to be approving)
|
Well, I guess that for now we just enable |
3348b96 to
e4587c6
Compare
|
@bors try jobs=aarch64-apple |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Implement opt-in debugger discovery for GDB and LLDB in bootstrap try-job: aarch64-apple
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0245046 to
333b2d0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
333b2d0 to
bee55cf
Compare
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 2e892ff failed: CI. Failed job:
|
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry |
This comment has been minimized.
This comment has been minimized.
Implement opt-in debugger discovery for GDB and LLDB in bootstrap GDB and LLDB is no longer automatically auto-discovered, you can opt into the previous behavior using `build.gdb/lldb = "discover"`. Note: this means that unless you opt into using a specific debugger, you won't run any `debuginfo` tests by default (except for `cdb`, which is still automatically detected). r? @jieyouxu
|
💔 Test for 52396cf failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing da86f4d (parent) -> 008fa22 (this PR) Test differencesShow 177 test diffsStage 2
(and 73 additional test diffs) Additionally, 4 doctest diffs were found. These are ignored, as they are noisy. Job group index Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 008fa22ce3f8d3c8dfaca2e6486043c2b21851eb --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Wut, why did |
|
Finished benchmarking commit (008fa22): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (secondary 4.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 489.287s -> 489.346s (0.01%) |
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
View all comments
GDB and LLDB is no longer automatically auto-discovered, you can opt into the previous behavior using
build.gdb/lldb = "discover".Note: this means that unless you opt into using a specific debugger, you won't run any
debuginfotests by default (except forcdb, which is still automatically detected).r? @jieyouxu