Build offload in dist-x86_64-linux CI job#159064
Draft
sgasho wants to merge 3 commits into
Draft
Conversation
rustbot
added
A-CI
Member
|
@bors delegate try |
Contributor
|
✌️ @sgasho, you can now perform try builds on this pull request! You can now post |
Contributor
Author
|
@bors try jobs=dist-x86_64-linux |
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 10, 2026
Build offload in dist-x86_64-linux CI job try-job: dist-x86_64-linux
This comment has been minimized.
This comment has been minimized.
Contributor
Contributor
Author
|
@bors try jobs=dist-x86_64-linux |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 12, 2026
Build offload in dist-x86_64-linux CI job try-job: dist-x86_64-linux
Contributor
|
💔 Test for 7b815a7 failed: CI. Failed job:
|
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
T-bootstrap
Contributor
Author
|
@bors try jobs=dist-x86_64-linux |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 13, 2026
Build offload in dist-x86_64-linux CI job try-job: dist-x86_64-linux
sgasho
commented
Jul 13, 2026
| pub fn copy_directory(src: &Utf8Path, dst: &Utf8Path) -> anyhow::Result<()> { | ||
| log::info!("Copying directory {src} to {dst}"); | ||
| fs_extra::dir::copy(src, dst, &CopyOptions::default().copy_inside(true))?; | ||
| fs_extra::dir::copy(src, dst, &CopyOptions::default().content_only(true))?; |
Contributor
Author
There was a problem hiding this comment.
I couldn't figure out why copy_inside(true) is used here. The latest CI failure seems related, so I'd like to try content_only(true).
Contributor
Author
There was a problem hiding this comment.
(I also feel that using copy_inside(true) in a function named copy_directory can lead to unexpected behavior, as seen in the latest CI failure. It does more than just copy the contents of src to dst)
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build std::offload in CI - dist-x86_64-linux