Rollup of 18 pull requests by JonathanBrouwer · Pull Request #158923 · rust-lang/rust

JonathanBrouwer · 2026-07-07T18:17:58Z

Successful merges:

Enable Enzyme on x86_64-apple #157385 (Enable Enzyme on x86_64-apple)
rustdoc: do not include extra stuff in span #157561 (rustdoc: do not include extra stuff in span)
std: unconditionally use preadv/pwritev on AArch64 macOS #158179 (std: unconditionally use preadv/pwritev on AArch64 macOS)
allow mGCA const arguments to fall back to anon consts #158617 (allow mGCA const arguments to fall back to anon consts)
disallow extern "custom" on wasm and spirv targets #158621 (disallow extern "custom" on wasm and spirv targets)
delegation: support mapping of all arguments with Self type #158690 (delegation: support mapping of all arguments with Self type)
Rename some body_id to body_def_id #158696 (Rename some body_id to body_def_id)
Fixes for QNX SDP 8 #158697 (Fixes for QNX SDP 8)
Clarify that LocalKey::try_with may return AccessError #158760 (Clarify that LocalKey::try_with may return AccessError)
Rewrite safety requirements for Allocator impls #157801 (Rewrite safety requirements for Allocator impls)
Fix typetree generation for differentiated functions #158333 (Fix typetree generation for differentiated functions)
powerpc64le_unknown_freebsd.rs: link with -lgcc #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc)
diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch)
Avoid unused braces lint for macro generated arguments #158791 (Avoid unused braces lint for macro generated arguments)
Use ci-mirrors in armhf-gnu for {busybox, ubuntu rootfs} artifacts #158802 (Use ci-mirrors in armhf-gnu for {busybox, ubuntu rootfs} artifacts)
Avoid final override ICE for RPITIT associated types #158841 (Avoid final override ICE for RPITIT associated types)
tests: catch up with LLVM returning f128 on the stack #158889 (tests: catch up with LLVM returning f128 on the stack)
delegation: add constraints to new generic args #158905 (delegation: add constraints to new generic args)

I define the concept of "equivalent allocators", in order to be able to talk about cloning allocators, and to give commonsense guarantees about stdlib `Allocator` impls. I define the concept of "invalidating a memory block" in order to be able to talk about users not being allowed to use a block of allocated memory after its allocator is "gone". An `Allocator` implementation is now allowed to invalidate its allocations when the allocator is mutated or when a lifetime in the allocator type expires. Mutation of an `Allocator` should sensibly be allowed to invalidate its allocations. For example, the `bumpalo` crates has a `Bump::reset` method that takes `&mut self` and invalidates all past allocations. Accesses via `&` still must not invalidate past allocations since, for example, `Box` provides `&` access to the allocator. I still had the "allocator destructor" clause as a separate clause from the `&mut` clause, to avoid questions about whether drop glue of types that don't implement `Drop` but have fields that implement `Drop` counts as creating a `&mut` to the whole thing. The "lifetime expiry" clause closes a hole/ambiguity on when an allocator is considered to be "dropped" if it does not have a destructor. Additionally, this clause matches what is required for `Box::into_pin` and `{Rc, Arc}::pin` to be sound. (Those methods have an `A: 'static` bound to prevent allocating via a `&MyAllocator` and then running `MyAllocator`'s destructor.)

This change prevents our lints from returning a span with stuff in it that isn't actually part of the doc comment. When that happens, it returns `None` instead.

It requires an allocation, and doesn't seem to help in practice. Fixes a nit found during review.

Co-authored-by: binarycat <binarycat@envs.net>

Starting with FreeBSD 16.0, powerpc64le switches to IEEE long double. 128 bit arithmetics are implemented in LLVM's compiler_rt, which is FreeBSD's libgcc. Link with it so that building on FreeBSD 16.0 succeeds - noop for earlier releases.

…e mismatch

… suggestion

…n suggestion

The docs stated that try_with will return an AccessError when the key has been destroyed. This is not guaranteed: on some platforms, TLS slots can be re-initialized during destruction, so the destroyed state cannot always be observed. Change 'will' to 'may' to accurately reflect the best-effort nature of the check.

…facts

…ure HRTB annotation

…estion

…r generation for memcpy. This moves a TA failure in the testcase from memcpy to a later location.

JonathanBrouwer · 2026-07-07T18:18:11Z

@bors r+ rollup=never p=5

rust-bors · 2026-07-07T18:18:14Z

📌 Commit fddf020 has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 18 pull requests Successful merges: - #157385 (Enable Enzyme on x86_64-apple) - #157561 (rustdoc: do not include extra stuff in span) - #158179 (std: unconditionally use `preadv`/`pwritev` on AArch64 macOS) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158621 (disallow `extern "custom"` on wasm and spirv targets) - #158690 (delegation: support mapping of all arguments with `Self` type) - #158696 (Rename some `body_id` to `body_def_id`) - #158697 (Fixes for QNX SDP 8) - #158760 (Clarify that `LocalKey::try_with` may return `AccessError`) - #157801 (Rewrite safety requirements for `Allocator` impls) - #158333 (Fix typetree generation for differentiated functions) - #158646 (powerpc64le_unknown_freebsd.rs: link with -lgcc) - #158701 ( diagnostics: suggest type annotation for closure params on HRTB FnOnce mismatch) - #158791 (Avoid unused braces lint for macro generated arguments) - #158802 (Use `ci-mirrors` in `armhf-gnu` for {busybox, ubuntu rootfs} artifacts) - #158841 (Avoid final override ICE for RPITIT associated types) - #158889 (tests: catch up with LLVM returning f128 on the stack) - #158905 (delegation: add constraints to new generic args)

rust-log-analyzer · 2026-07-07T19:57:53Z

The job dist-x86_64-linux-alt failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

 Documenting rustc-main v0.0.0 (/checkout/compiler/rustc)
warning: redundant explicit link target
    --> compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs:2373:5
     |
2373 |     /// Lower a [`hir::ConstArg`] to a (type-level) [`ty::Const`](Const).
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ explicit target `Const` is redundant because label `ty::Const` resolves to same destination
     |
     = note: when a link's destination is not specified,
             the label is used to resolve intra-doc links
     = note: `#[warn(rustdoc::redundant_explicit_links)]` on by default

---
 Documenting rustc_ty_utils v0.0.0 (/checkout/compiler/rustc_ty_utils)
error: `rustc_hir_analysis` (lib doc) generated 1 warning
error: warnings are denied by `build.warnings` configuration
warning: build failed, waiting for other jobs to finish...
Bootstrap failed while executing `dist --host x86_64-unknown-linux-gnu --target x86_64-unknown-linux-gnu --include-default-paths build-manifest bootstrap`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo doc --target x86_64-unknown-linux-gnu -Zbinary-dep-depinfo -j 8 -Zroot-dir=/checkout --locked --color=always --profile=release --features 'jemalloc llvm rustc' --manifest-path /checkout/compiler/rustc/Cargo.toml -Zskip-rustdoc-fingerprint --no-deps -Zrustdoc-map -p rustc-main -p rustc_abi -p rustc_arena -p rustc_ast -p rustc_ast_ir -p rustc_ast_lowering -p rustc_ast_passes -p rustc_ast_pretty -p rustc_attr_parsing -p rustc_baked_icu_data -p rustc_borrowck -p rustc_builtin_macros -p rustc_codegen_llvm -p rustc_codegen_ssa -p rustc_const_eval -p rustc_data_structures -p rustc_driver -p rustc_driver_impl -p rustc_error_codes -p rustc_error_messages -p rustc_errors -p rustc_expand -p rustc_feature -p rustc_fs_util -p rustc_graphviz -p rustc_hashes -p rustc_hir -p rustc_hir_analysis -p rustc_hir_id -p rustc_hir_pretty -p rustc_hir_typeck -p rustc_incremental -p rustc_index -p rustc_index_macros -p rustc_infer -p rustc_interface -p rustc_lexer -p rustc_lint -p rustc_lint_defs -p rustc_llvm -p rustc_log -p rustc_macros -p rustc_metadata -p rustc_middle -p rustc_mir_build -p rustc_mir_dataflow -p rustc_mir_transform -p rustc_monomorphize -p rustc_next_trait_solver -p rustc_parse -p rustc_parse_format -p rustc_passes -p rustc_pattern_analysis -p rustc_privacy -p rustc_proc_macro -p rustc_public -p rustc_public_bridge -p rustc_query_impl -p rustc_resolve -p rustc_sanitizers -p rustc_serialize -p rustc_session -p rustc_span -p rustc_symbol_mangling -p rustc_target -p rustc_thread_pool -p rustc_trait_selection -p rustc_traits -p rustc_transmute -p rustc_ty_utils -p rustc_type_ir -p rustc_type_ir_macros -p rustc_windows_rc [workdir=/checkout]` failed with exit code 101
Created at: src/bootstrap/src/core/build_steps/doc.rs:930:25
Executed at: src/bootstrap/src/core/build_steps/doc.rs:991:26

--- BACKTRACE vvv
   0: <bootstrap::utils::exec::DeferredCommand>::finish_process
             at /checkout/src/bootstrap/src/utils/exec.rs:939:17
   1: <bootstrap::utils::exec::DeferredCommand>::wait_for_output::<&bootstrap::utils::exec::ExecutionContext>
             at /checkout/src/bootstrap/src/utils/exec.rs:831:21
   2: <bootstrap::utils::exec::ExecutionContext>::run
             at /checkout/src/bootstrap/src/utils/exec.rs:741:45
   3: <bootstrap::utils::exec::BootstrapCommand>::run::<&bootstrap::core::builder::Builder>
             at /checkout/src/bootstrap/src/utils/exec.rs:339:27
   4: <bootstrap::core::build_steps::doc::Rustc as bootstrap::core::builder::Step>::run
             at /checkout/src/bootstrap/src/core/build_steps/doc.rs:991:26
   5: <bootstrap::core::builder::Builder>::ensure::<bootstrap::core::build_steps::doc::Rustc>
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1607:36
   6: <bootstrap::core::build_steps::doc::Rustc as bootstrap::core::builder::Step>::make_run
             at /checkout/src/bootstrap/src/core/build_steps/doc.rs:900:21
   7: <bootstrap::core::builder::StepDescription>::maybe_run
             at /checkout/src/bootstrap/src/core/builder/mod.rs:476:13
   8: bootstrap::core::builder::cli_paths::match_paths_to_steps_and_run
             at /checkout/src/bootstrap/src/core/builder/cli_paths.rs:141:22
   9: <bootstrap::core::builder::Builder>::run_step_descriptions
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1140:9
---
  12: <bootstrap::core::builder::Builder>::ensure::<bootstrap::core::build_steps::dist::Docs>
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1607:36
  13: <bootstrap::core::build_steps::dist::Docs as bootstrap::core::builder::Step>::make_run
             at /checkout/src/bootstrap/src/core/build_steps/dist.rs:79:21
  14: <bootstrap::core::builder::StepDescription>::maybe_run
             at /checkout/src/bootstrap/src/core/builder/mod.rs:476:13
  15: bootstrap::core::builder::cli_paths::match_paths_to_steps_and_run
             at /checkout/src/bootstrap/src/core/builder/cli_paths.rs:141:22
  16: <bootstrap::core::builder::Builder>::run_step_descriptions
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1140:9
  17: <bootstrap::core::builder::Builder>::execute_cli
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1119:14
  18: <bootstrap::Build>::build
             at /checkout/src/bootstrap/src/lib.rs:803:25
  19: bootstrap::main
             at /checkout/src/bootstrap/src/bin/main.rs:130:11
  20: <fn() as core::ops::function::FnOnce<()>>::call_once
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/core/src/ops/function.rs:250:5
  21: std::sys::backtrace::__rust_begin_short_backtrace::<fn(), ()>
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/sys/backtrace.rs:166:18
  22: std::rt::lang_start::<()>::{closure#0}
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/rt.rs:206:18
  23: <&dyn core::ops::function::Fn<(), Output = i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe as core::ops::function::FnOnce<()>>::call_once
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/core/src/ops/function.rs:287:21
  24: std::panicking::catch_unwind::do_call::<&dyn core::ops::function::Fn<(), Output = i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe, i32>
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/panicking.rs:581:40
  25: std::panicking::catch_unwind::<i32, &dyn core::ops::function::Fn<(), Output = i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe>
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/panicking.rs:544:19
  26: std::panic::catch_unwind::<&dyn core::ops::function::Fn<(), Output = i32> + core::marker::Sync + core::panic::unwind_safe::RefUnwindSafe, i32>
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/panic.rs:359:14
  27: std::rt::lang_start_internal::{closure#0}
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/rt.rs:175:24
  28: std::panicking::catch_unwind::do_call::<std::rt::lang_start_internal::{closure#0}, isize>
             at /rustc/0417c25868d6dfbd1c291dfeae950504faa6f790/library/std/src/panicking.rs:581:40
---
  34: __libc_start_main
  35: <unknown>


Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:39:40
  local time: Tue Jul  7 19:57:39 UTC 2026
  network time: Tue, 07 Jul 2026 19:57:39 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

rust-bors · 2026-07-07T19:58:24Z

💔 Test for e38cd22 failed: CI. Failed job:

auto - dist-x86_64-linux-alt (web logs, enhanced plaintext logs)

rust-bors · 2026-07-07T20:26:31Z

PR #157561, which is a member of this rollup, was unapproved.

theemathas and others added 30 commits June 12, 2026 19:23

Address feedback comments.

e9929d7

rustdoc: do not include extra stuff in span

84f2896

This change prevents our lints from returning a span with stuff in it that isn't actually part of the doc comment. When that happens, it returns `None` instead.

Fix unbalanced_ticks when doc isn't contiguous

2001b88

Add test case for split missing punctuation

e66a504

Skip the unhelpful binary search

f7302b9

It requires an allocation, and doesn't seem to help in practice. Fixes a nit found during review.

Rename span and line_bytes to more specific

b66a23f

Co-authored-by: binarycat <binarycat@envs.net>

Use an intermediate variable for readability

f93f2e4

Co-authored-by: binarycat <binarycat@envs.net>

Add clarifying comment

7975dc7

Co-authored-by: binarycat <binarycat@envs.net>

Remove unused Option return

4d83004

Handle span failure in redundant_explicit_links

9438aac

Add clarifying comment for shrink_to_hi

74c203d

Handle block doc comments better

162a90c

Enable Enzyme for x86_64-apple

310bfad

bump download-ci-llvm-stamp

34e0561

Fix conditions of & API invalidating memory blocks.

d847075

diagnostics: suggest type annotation for closure params on HRTB FnOnc…

a00bdac

…e mismatch

test: bless existing UI tests affected by new closure type annotation…

155ead1

… suggestion

test: bless remaining UI tests affected by new closure type annotatio…

5817f14

…n suggestion

ci: use ci-mirrors in armhf-gnu for {busybox, ubuntu rootfs} arti…

340e079

…facts

diagnostics: improve suggestion message and add rustfix test for clos…

0e0b98a

…ure HRTB annotation

test: bless nll UI tests affected by new closure type annotation sugg…

049b3a3

…estion

Avoid unused braces lint for macro-provided call arguments

b50b5b2

add regression test for final RPITIT override panic

448e0f8

avoid final override diagnostics for non-function associated items

5a5f78d

allow mGCA const arguments to fall back to anon consts

7f39e9f

Fix typetree generation for arguments, like slices and re-enable thei…

de73ac0

…r generation for memcpy. This moves a TA failure in the testcase from memcpy to a later location.

Refactor the Type to TypeTree parser into a large match

6bb1c07

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 7, 2026

JonathanBrouwer mentioned this pull request Jul 7, 2026

rustdoc: do not include extra stuff in span #157561

Open

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 7, 2026

JonathanBrouwer closed this Jul 7, 2026

rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Rollup of 18 pull requests#158923

Rollup of 18 pull requests#158923
JonathanBrouwer wants to merge 61 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-HAAKMUz

JonathanBrouwer commented Jul 7, 2026

Uh oh!

JonathanBrouwer commented Jul 7, 2026

Uh oh!

rust-bors Bot commented Jul 7, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Jul 7, 2026

Uh oh!

rust-bors Bot commented Jul 7, 2026

Uh oh!

rust-bors Bot commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Jul 7, 2026

Uh oh!

JonathanBrouwer commented Jul 7, 2026

Uh oh!

rust-bors Bot commented Jul 7, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Jul 7, 2026

Uh oh!

rust-bors Bot commented Jul 7, 2026

Uh oh!

rust-bors Bot commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants