Use `LowerAvailableDepth::No` for normalizes-to goal itself instead of its nested goals by ShoyuVanilla · Pull Request #158705 · rust-lang/rust

ShoyuVanilla · 2026-07-02T23:02:28Z

Might fix perf regressions in #157718 (comment)

ShoyuVanilla · 2026-07-02T23:04:10Z

Use `IncreaseDepth::No` for normalizes-to goal itself instead of its nested goals

rust-bors · 2026-07-03T01:13:52Z

☀️ Try build successful (CI)
Build commit: e3dd511 (e3dd511562be8a5b2b1b46276fa6a16bffc1580f)
Base parent: c397dae (c397dae808f70caebab1fc4e11b3edf7e59f58c7)

rust-timer · 2026-07-03T01:54:07Z

Finished benchmarking commit (e3dd511): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-37.3%	[-37.5%, -37.1%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -8.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-10.8%	[-12.8%, -5.5%]	4
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 5.5%, secondary -16.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	5.5%	[5.5%, 5.5%]	1
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-19.7%	[-36.4%, -2.1%]	6
All ❌✅ (primary)	5.5%	[5.5%, 5.5%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.944s -> 485.308s (-0.13%)
Artifact size: 393.37 MiB -> 393.33 MiB (-0.01%)

ShoyuVanilla · 2026-07-03T02:00:21Z

r? lcnr
I was wrong and you were totally correct on this 😅

lcnr · 2026-07-03T09:00:06Z

        goal: Goal<I, I::Predicate>,
        stalled_on: Option<GoalStalledOn<I>>,
-        increase_depth_for_nested: IncreaseDepthForNested,
+        increase_depth_for_nested: IncreaseDepth,


IncrementDepth and also rename the function argument name maybe 🤔 LowerAvailableDepth?

View changes since the review

Since we track available depth, LowerAvailableDepth sounds good 😄

lcnr · 2026-07-03T09:00:44Z

naming nit, otherwise r=me 😁

…f its nested goals

ShoyuVanilla · 2026-07-04T06:04:35Z

@bors r=lcnr

rust-bors · 2026-07-04T06:04:38Z

📌 Commit ed57bc8 has been approved by lcnr

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

rust-bors · 2026-07-06T11:56:15Z

☀️ Test successful - CI
Approved by: lcnr
Duration: 3h 26m 19s
Pushing 3c00c96 to main...

github-actions · 2026-07-06T11:59:25Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3659db0 (parent) -> 3c00c96 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3c00c96d3af4d5b5e101e56cc161a608b21366ee --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-arm-linux-musl: 1h 37m -> 59m 13s (-39.2%)
x86_64-msvc-2: 1h 45m -> 2h 26m (+39.1%)
x86_64-gnu: 1h 57m -> 2h 37m (+33.6%)
x86_64-msvc-1: 2h 41m -> 2h (-25.5%)
x86_64-gnu-tools: 1h 6m -> 50m 30s (-24.5%)
dist-x86_64-solaris: 1h 33m -> 1h 15m (-19.8%)
tidy: 2m 58s -> 3m 27s (+16.4%)
dist-x86_64-apple: 1h 38m -> 1h 22m (-16.1%)
x86_64-msvc-ext2: 1h 46m -> 2h (+14.0%)
x86_64-gnu-llvm-22-1: 1h 8m -> 1h 17m (+13.0%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-07-06T12:42:14Z

Finished benchmarking commit (3c00c96): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-37.4%	[-37.7%, -37.2%]	3
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.4%, secondary -6.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.4%	[0.6%, 2.3%]	2
Regressions ❌ (secondary)	6.2%	[6.2%, 6.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-10.1%	[-13.1%, -2.5%]	4
All ❌✅ (primary)	1.4%	[0.6%, 2.3%]	2

Cycles

Results (secondary -27.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-27.9%	[-36.5%, -3.9%]	4
All ❌✅ (primary)	-	-	0

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 491.532s -> 491.018s (-0.10%)
Artifact size: 388.93 MiB -> 388.45 MiB (-0.12%)

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 2, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jul 2, 2026

Auto merge of #158705 - ShoyuVanilla:search-graph-depth-fixup, r=<try>

e3dd511

Use `IncreaseDepth::No` for normalizes-to goal itself instead of its nested goals

This comment has been minimized.

Sign in to view

ShoyuVanilla force-pushed the search-graph-depth-fixup branch from 25d5250 to 8c7b929 Compare July 2, 2026 23:13

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 3, 2026

rustbot assigned lcnr Jul 3, 2026

ShoyuVanilla marked this pull request as ready for review July 3, 2026 02:00

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 3, 2026

lcnr reviewed Jul 3, 2026

View reviewed changes

Use LowerAvailableDepth::No for normalizes-to goal itself instead o…

ed57bc8

…f its nested goals

ShoyuVanilla force-pushed the search-graph-depth-fixup branch from 8c7b929 to ed57bc8 Compare July 4, 2026 02:32

ShoyuVanilla changed the title ~~Use IncreaseDepth::No for normalizes-to goal itself instead of its nested goals~~ Use LowerAvailableDepth::No for normalizes-to goal itself instead of its nested goals Jul 4, 2026

ShoyuVanilla mentioned this pull request Jul 4, 2026

Do not increase depth when evaluating nested goals of NormalizesTo #157718

Merged

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2026

rust-bors Bot merged commit 3c00c96 into rust-lang:main Jul 6, 2026
14 checks passed

rustbot added this to the 1.99.0 milestone Jul 6, 2026

This was referenced Jul 6, 2026

Use TyOrConstInferVar in the next solver, fix #158441 #158436

Draft

Move fast paths around to gain a bit of new-solver perf #158249

Open

ShoyuVanilla deleted the search-graph-depth-fixup branch July 6, 2026 11:57

panstromek mentioned this pull request Jul 6, 2026

Rollup of 6 pull requests #158639

Merged

Uh oh!

Uh oh!

Conversation

ShoyuVanilla commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShoyuVanilla commented Jul 2, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Jul 3, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Jul 3, 2026

Overall result: ✅ improvements - no action needed

Uh oh!

ShoyuVanilla commented Jul 3, 2026

Uh oh!

lcnr Jul 3, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lcnr commented Jul 3, 2026

Uh oh!

ShoyuVanilla commented Jul 4, 2026

Uh oh!

rust-bors Bot commented Jul 4, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 6, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 6, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Jul 6, 2026

Overall result: ✅ improvements - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ShoyuVanilla commented Jul 2, 2026 •

edited

Loading

lcnr Jul 3, 2026 •

edited by rustbot

Loading