Allow BackwardIncompatibleDropHint in polonius legacy by KiChjang · Pull Request #158384 · rust-lang/rust

KiChjang · 2026-06-25T03:29:41Z

Very simple fix to make StatementKind::BackwardIncompatibleDropHint a noop and prevent it from panicking when collecting loan invalidations while running -Zpolonius=legacy.

rustbot · 2026-06-25T03:29:46Z

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 19 candidates

KiChjang · 2026-06-25T03:30:14Z

r? @lqd

KiChjang · 2026-07-08T15:45:34Z

This is actually a small enough PR that anyone can just review, so r? @folkertdev

lqd · 2026-07-08T16:01:46Z

Isn't this hint only used when migrating to edition2024? Why do you want to do this?

Especially since we're planning on removing the legacy implementation in due time.

KiChjang · 2026-07-08T17:53:30Z

@lqd you're right, I'm simply just trying to resolve the linked issue. If it isn't worth doing, then I suggest closing both this PR and the issue.

folkertdev · 2026-07-08T18:59:38Z

r? lqd

lqd · 2026-07-08T19:00:01Z

r? me

It's indeed not going to be a super long-term thing, but you cared, and did the work already, so let's land it (after moving the test).

Thanks!

lqd · 2026-07-08T19:12:14Z

@bors squash

rust-bors · 2026-07-08T19:12:39Z

🔨 2 commits were squashed into 6573670.

lqd · 2026-07-08T19:14:41Z

@bors r+ rollup

rust-bors · 2026-07-08T19:14:44Z

📌 Commit 6573670 has been approved by lqd

It is now in the queue for this repository.

…rop-hint, r=lqd Allow BackwardIncompatibleDropHint in polonius legacy Fixes rust-lang#157568. Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.

lqd · 2026-07-08T21:12:19Z

Darn, why did CI pass before. This will make the rollup fail :(

@bors r-

rust-bors · 2026-07-08T21:12:25Z

This pull request was unapproved.

This PR was contained in a rollup (#158973), which was unapproved.

View changes since this unapproval

* Allow BackwardIncompatibleDropHint in polonius legacy * Move test file to be under polonius * Remove resolved crash test file

rustbot · 2026-07-09T16:37:37Z

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

rustbot · 2026-07-09T16:37:39Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

KiChjang · 2026-07-09T16:40:16Z

@lqd because main changed and added a crash test for the issue. We weren't fast enough :(

lqd · 2026-07-09T19:19:16Z

Incredible :)

Thanks for fixing it. Again.

@bors r+ rollup

rust-bors · 2026-07-09T19:19:19Z

📌 Commit 23cf412 has been approved by lqd

It is now in the queue for this repository.

…rop-hint, r=lqd Allow BackwardIncompatibleDropHint in polonius legacy Fixes rust-lang#157568. Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.

…uwer Rollup of 24 pull requests Successful merges: - #150946 (intrinsics: Add a fallback for non-const libm float functions) - #158510 (Enable `static_position_independent_executables` on all gnu and musl targets) - #158541 (Move `std::io::Write` to `core::io`) - #158899 (Fix `unaligned_volatile_store` by removing `MemFlags::UNALIGNED`) - #156027 (Consider captured regions for opaque type region liveness.) - #156370 (Reject linked dylib EII default overrides) - #156508 (Infer all anonymous lifetimes in assoc consts as `'static`) - #157561 (rustdoc: do not include extra stuff in span) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158645 (Fix splat ICEs and ban it in closures) - #158859 (Improve `-Zls` diagnostic message on `.rs` files) - #158988 (Redo `TokenStreamIter`) - #158347 (Improve generic parameters handling for #[diagnostic::on_const]) - #158384 (Allow BackwardIncompatibleDropHint in polonius legacy) - #158722 (delegation: do not always inherit `ConstArgHasType` predicates) - #158739 (view-types: HIR lowering) - #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent) - #158883 (tests: fix enum-match.rs to handle LLVM 23) - #158886 (Add documentation for the `no_std` attribute) - #158940 (Implement feature `char_to_u32`) - #158951 (Merge three `MaxUniverse`s into one) - #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places") - #158995 (Use REST API in linkchecker script) - #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes)

…rop-hint, r=lqd Allow BackwardIncompatibleDropHint in polonius legacy Fixes rust-lang#157568. Very simple fix to make `StatementKind::BackwardIncompatibleDropHint` a noop and prevent it from panicking when collecting loan invalidations while running `-Zpolonius=legacy`.

Rollup of 24 pull requests Successful merges: - #150946 (intrinsics: Add a fallback for non-const libm float functions) - #158541 (Move `std::io::Write` to `core::io`) - #156027 (Consider captured regions for opaque type region liveness.) - #156370 (Reject linked dylib EII default overrides) - #156508 (Infer all anonymous lifetimes in assoc consts as `'static`) - #157561 (rustdoc: do not include extra stuff in span) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158645 (Fix splat ICEs and ban it in closures) - #158859 (Improve `-Zls` diagnostic message on `.rs` files) - #158988 (Redo `TokenStreamIter`) - #158347 (Improve generic parameters handling for #[diagnostic::on_const]) - #158384 (Allow BackwardIncompatibleDropHint in polonius legacy) - #158722 (delegation: do not always inherit `ConstArgHasType` predicates) - #158739 (view-types: HIR lowering) - #158877 (borrowck: Keep returned `path` from `best_blame_constraint()` consistent) - #158883 (tests: fix enum-match.rs to handle LLVM 23) - #158886 (Add documentation for the `no_std` attribute) - #158940 (Implement feature `char_to_u32`) - #158951 (Merge three `MaxUniverse`s into one) - #158960 (Fix bootstrap submodule path prefix matching) - #158961 (Reapply "LLVM 23: Run AssignGUIDPass in some places") - #158995 (Use REST API in linkchecker script) - #158996 ([compiler] Implement `PartialOrd` via `Ord` for `Span` and newtype_indexes) - #159036 (bootstrap: expand '@argfile' arguments to rustc shim)

rustbot assigned folkertdev Jun 25, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 25, 2026

rustbot assigned lqd and unassigned folkertdev Jun 25, 2026

rustbot assigned folkertdev and unassigned lqd Jul 8, 2026

lqd reviewed Jul 8, 2026

View reviewed changes

Comment thread tests/ui/nll/polonius/allow-backward-incompatible-drop-hint.rs

rustbot assigned lqd and unassigned folkertdev Jul 8, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot force-pushed the allow-backward-incompat-drop-hint branch from 77a6ade to 6573670 Compare July 8, 2026 19:12

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer mentioned this pull request Jul 8, 2026

Rollup of 25 pull requests #158973

Closed

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 8, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 8, 2026

Allow BackwardIncompatibleDropHint in polonius legacy

23cf412

* Allow BackwardIncompatibleDropHint in polonius legacy * Move test file to be under polonius * Remove resolved crash test file

KiChjang force-pushed the allow-backward-incompat-drop-hint branch from 6573670 to 23cf412 Compare July 9, 2026 16:37

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 9, 2026

JonathanBrouwer mentioned this pull request Jul 9, 2026

Rollup of 24 pull requests #159037

Closed

jhpratt mentioned this pull request Jul 9, 2026

Rollup of 25 pull requests #159045

Closed

jhpratt mentioned this pull request Jul 10, 2026

Rollup of 24 pull requests #159046

Open

Uh oh!

Uh oh!

Conversation

KiChjang commented Jun 25, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jun 25, 2026

Uh oh!

KiChjang commented Jun 25, 2026

Uh oh!

KiChjang commented Jul 8, 2026

Uh oh!

lqd commented Jul 8, 2026

Uh oh!

KiChjang commented Jul 8, 2026

Uh oh!

Uh oh!

folkertdev commented Jul 8, 2026

Uh oh!

lqd commented Jul 8, 2026

Uh oh!

lqd commented Jul 8, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jul 8, 2026

Uh oh!

lqd commented Jul 8, 2026

Uh oh!

rust-bors Bot commented Jul 8, 2026

Uh oh!

This comment has been minimized.

lqd commented Jul 8, 2026

Uh oh!

rust-bors Bot commented Jul 8, 2026

Uh oh!

rustbot commented Jul 9, 2026

Uh oh!

rustbot commented Jul 9, 2026

Uh oh!

KiChjang commented Jul 9, 2026

Uh oh!

lqd commented Jul 9, 2026

Uh oh!

rust-bors Bot commented Jul 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

KiChjang commented Jun 25, 2026 •

edited by rustbot

Loading