Library support for aarch64-unknown-linux-pauthtest target by jchlanda · Pull Request #156548 · rust-lang/rust

jchlanda · 2026-05-13T14:16:43Z

This is a follow up to #155722, adding library support for the target.

jchlanda · 2026-05-13T14:17:48Z

The relevant change is only in the two most recent commits, the rest is from the target introduction PR.

jchlanda · 2026-05-18T13:19:24Z

@davidtwco, @folkertdev, @tgross35, @madsmtm FWI this is a follow up to #155722
This will have to be rebased once #155722 is merged.

rustbot · 2026-05-19T12:16:41Z

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

The GCC codegen subtree was changed

cc @antoyo, @GuillaumeGomez

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

Some changes occurred in src/doc/rustc/src/platform-support

cc @Noratrieb

This PR modifies tests/auxiliary/minicore.rs.

cc @jieyouxu

These commits modify compiler targets.
(See the Target Tier Policy.)

rustbot · 2026-05-19T12:16:44Z

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 20 candidates

rustbot · 2026-06-30T11:45:11Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

folkertdev

@davidtwco I'd appreciate your review here too.

View changes since this review

folkertdev · 2026-06-30T11:56:20Z

+// For pauthtest the only supported unwinding mechanism is provided by libunwind.
+#[cfg(target_abi = "pauthtest")]
+#[link(name = "unwind")]
+unsafe extern "C" {}


this is making some assumptions about the target_os values that can occur in combination with target_abi = "pauthtest" right? Can you make those assumptions explicit in a comment here?

I've re-worded it to mention that the only supported OS for pauthtest target is Linux.

folkertdev · 2026-06-30T11:57:57Z

+                // `pacib` corresponds to `ptrauth_key_process_dependent_code` in <ptrauth.h>.
+                core::arch::asm!(
+                    "pacib {addr}, {sp}",
+                    addr = inout(reg) addr,
+                    sp = in(reg) sp,
+                    options(nostack, preserves_flags)
+                );


should this be in stdarch? or does it really only make sense to use inline assembly here?

I originally introduced an intrinsic for resigning. Then discussed it with @davidtwco, and decided that inline asm was the better approach. Providing an intrinsic could potentially introduce a security risk by making it easier to construct signing oracles. As for stdarch, my understanding is that there is ongoing work to provide more comprehensive pointer authentication support, but to my knowledge it has not been completed yet.

Yeah, I'd like to propose eventually a handful of more complete pointer authentication intrinsics but making sure they can't be used as signing oracles is difficult so we've not proposed anything yet

rustbot · 2026-06-30T11:59:20Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

jchlanda · 2026-07-01T14:52:45Z

Hi all (@davidtwco, @folkertdev, @tgross35, @madsmtm, @bjorn3),

The PR introducing the pauthtest target has been merged into main. I'd be very grateful if we could move this one forward as well.

Thank you!

folkertdev

r? davidtwco

View changes since this review

davidtwco

Looks good to me, r=me after checking if the suggestion below works

View changes since this review

davidtwco · 2026-07-06T11:13:33Z

@bors r+ rollup

rust-bors · 2026-07-06T11:13:36Z

📌 Commit 4c59d2c has been approved by davidtwco

It is now in the queue for this repository.

Library support for aarch64-unknown-linux-pauthtest target This is a follow up to rust-lang#155722, adding library support for the target.

JonathanBrouwer · 2026-07-06T15:08:29Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #158858 (comment)

rust-bors · 2026-07-06T15:08:37Z

This pull request was unapproved.

This PR was contained in a rollup (#158858), which was unapproved.

View changes since this unapproval

jchlanda · 2026-07-06T15:57:14Z

💔 I suspect this PR failed tests as part of a rollup @bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #158858 (comment)

I addressed the failure in b749630.
Thank you.

jchlanda · 2026-07-07T09:49:41Z

@bors try

rust-bors · 2026-07-07T09:49:45Z

@jchlanda: 🔑 Insufficient privileges: not in try users

This was referenced May 13, 2026

Introduce aarch64-unknown-linux-pauthtest target #155722

Merged

AArch64 Pointer Authentication using aarch64-unknown-linux-pauthtest target on Linux ELF platforms rust-lang/rust-project-goals#618

Open

jchlanda marked this pull request as ready for review May 19, 2026 12:16

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 19, 2026

rustbot assigned folkertdev May 19, 2026

jchlanda mentioned this pull request May 19, 2026

Pointer authentication config and user facing options #156712

Open

jchlanda force-pushed the jakub/pac_lib branch from 72ea191 to 0ae156a Compare May 26, 2026 14:11

This comment has been minimized.

Sign in to view

jchlanda mentioned this pull request May 27, 2026

Add support for aarch64-unknown-linux-pauthtest rust-lang/backtrace-rs#755

Open

jchlanda force-pushed the jakub/pac_lib branch from 0ae156a to 6f7739c Compare May 27, 2026 06:39

jchlanda mentioned this pull request Jun 1, 2026

Add support for AArch64 Pointer Authentication ABI in Rust #148640

Open

jchlanda force-pushed the jakub/pac_lib branch from 6f7739c to 50a986f Compare June 1, 2026 11:04

This comment has been minimized.

Sign in to view

jchlanda force-pushed the jakub/pac_lib branch from 50a986f to c4209ee Compare June 1, 2026 11:28

This comment has been minimized.

Sign in to view

jchlanda force-pushed the jakub/pac_lib branch from c4209ee to ded997e Compare June 1, 2026 12:08

folkertdev requested changes Jun 30, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 30, 2026

folkertdev approved these changes Jul 1, 2026

View reviewed changes

rustbot assigned davidtwco and unassigned folkertdev Jul 1, 2026

davidtwco reviewed Jul 2, 2026

View reviewed changes

Comment thread library/std/src/sys/personality/gcc.rs Outdated

davidtwco approved these changes Jul 6, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 6, 2026

JonathanBrouwer mentioned this pull request Jul 6, 2026

Rollup of 12 pull requests #158858

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2026

jchlanda added 5 commits July 6, 2026 15:55

Add library support for aarch64-unknown-linux-pauthtest

eef7f2e

Use target_env = "musl" & target_abi = "pauthtest" instead of env

1a7135c

Update landing pad to use addr()

d0b4c46

Use rust_force_inline on sign_lpad function

038cb8d

Set correct cfg_select for sign_lpad

b749630

jchlanda force-pushed the jakub/pac_lib branch from 4c59d2c to b749630 Compare July 6, 2026 15:55

Uh oh!

Uh oh!

Conversation

jchlanda commented May 13, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jchlanda commented May 13, 2026

Uh oh!

jchlanda commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 19, 2026

Uh oh!

rustbot commented May 19, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Jun 30, 2026

Uh oh!

folkertdev left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

folkertdev Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

jchlanda Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

folkertdev Jun 30, 2026

Choose a reason for hiding this comment

Uh oh!

jchlanda Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

davidtwco Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

rustbot commented Jun 30, 2026

Uh oh!

jchlanda commented Jul 1, 2026

Uh oh!

folkertdev left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

davidtwco left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

davidtwco commented Jul 6, 2026

Uh oh!

rust-bors Bot commented Jul 6, 2026

Uh oh!

JonathanBrouwer commented Jul 6, 2026

Uh oh!

rust-bors Bot commented Jul 6, 2026

Uh oh!

jchlanda commented Jul 6, 2026

Uh oh!

jchlanda commented Jul 7, 2026

Uh oh!

rust-bors Bot commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jchlanda commented May 13, 2026 •

edited by rustbot

Loading

jchlanda commented May 18, 2026 •

edited

Loading

folkertdev left a comment •

edited by rustbot

Loading

folkertdev left a comment •

edited by rustbot

Loading

davidtwco left a comment •

edited by rustbot

Loading