Restrict newtype constant wrapping to actual type aliases#3390
Merged
Conversation
armoha
force-pushed
the
strict-newtype-alias
branch
from
a47de8e to
594fe6f
Compare
armoha
force-pushed
the
strict-newtype-alias
branch
from
594fe6f to
8edd7a3
Compare
emilio
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3303
alias_stylehelper method fall backs toctx.options().default_alias_stylewithout checking if the item is actually a typedef/alias, resulting in matching built-in primitives to new type variant. The fix usesItemResolverand.through_type_refs()to unwrap C type qualifiers (e.g.const,volatile) and verifies that the type kind is alias.