Skip to content

fix: add null check to tidname on HeaderView #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minorllama wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: add null check to tidname on HeaderView #515

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
321c791
add null check to tidname on HeaderView
Jul 13, 2026
2c30fbc
remove commented out old code mod.rs
minorllama Jul 14, 2026
fd54af1
linting:cargo fmt + clippy
Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/bam/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1439,7 +1439,12 @@ impl HeaderView {
}

pub fn tid2name(&self, tid: u32) -> &[u8] {
unsafe { ffi::CStr::from_ptr(htslib::sam_hdr_tid2name(self.inner, tid as i32)).to_bytes() }
let ptr = unsafe { htslib::sam_hdr_tid2name(self.inner, tid as i32) };
if ptr.is_null() {
b""
} else {
unsafe { ffi::CStr::from_ptr(ptr).to_bytes() }
}
}

pub fn target_count(&self) -> u32 {
Expand Down Expand Up @@ -3183,6 +3188,13 @@ CCCCCCCCCCCCCCCCCCC"[..],
assert_eq!(expected, actual);
}

#[test]
fn test_nonexistent_tidname() {
let header = Header::new();
let header_view = HeaderView::from_header(&header);
assert_eq!(b"", header_view.tid2name(0));
}

// #[test]
// fn test_number_mapped_and_unmapped_cram() {
// let mut reader = IndexedReader::from_path("test/test_cram.cram").unwrap();
Expand Down
Loading