fix(cli): reject unrecognized flags instead of treating them as issue ids (#2) by bougyman · Pull Request #4 · rubyists/linear-cli

bougyman · 2026-08-08T15:31:03Z

issue list/take/update all set allow_unknown_args: true so bare tokens
(e.g. CRY-1) can be captured as issue ids via result.unknown - Optimus
has no type: :array equivalent for positional args. That same bucket
also silently swallowed any unrecognized flag (a typo, or a real flag
the subcommand just doesn't have, like --mine on issue list), which
then got looked up as a literal issue id instead of erroring - a raw
%Ash.Error.Unknown{} dump reaching the user.

run/3 now filters result.unknown for anything flag-shaped before ever
calling the command, returning a clean {:smells_bad, "unrecognized
option(s): ..."} (exit 22) instead. Every other subcommand already has
this covered by Optimus's own parser (allow_unknown_args: false
rejects unknown args before we ever see a parse_result), so this only
ever fires for the three subcommands that needed the escape hatch.

Per the issue: --mine itself is intentionally not being added -
--no-mine already covers it (--mine is the implied default).

… ids (#2) issue list/take/update all set allow_unknown_args: true so bare tokens (e.g. CRY-1) can be captured as issue ids via result.unknown - Optimus has no type: :array equivalent for positional args. That same bucket also silently swallowed any unrecognized flag (a typo, or a real flag the subcommand just doesn't have, like --mine on issue list), which then got looked up as a literal issue id instead of erroring - a raw %Ash.Error.Unknown{} dump reaching the user. run/3 now filters result.unknown for anything flag-shaped before ever calling the command, returning a clean {:smells_bad, "unrecognized option(s): ..."} (exit 22) instead. Every other subcommand already has this covered by Optimus's own parser (allow_unknown_args: false rejects unknown args before we ever see a parse_result), so this only ever fires for the three subcommands that needed the escape hatch. Per the issue: --mine itself is intentionally not being added - --no-mine already covers it (--mine is the implied default).

Copilot

Pull request overview

This PR improves linear-cli’s handling of subcommands that enable allow_unknown_args: true (to capture bare issue IDs) by rejecting flag-shaped unknown tokens up front, preventing typos/unimplemented flags from being interpreted as issue identifiers and causing confusing Ash error dumps.

Changes:

Added reject_unknown_flags/1 gating in run/3 to turn unknown -/---prefixed tokens into a clean {:smells_bad, "unrecognized option(s): ..."} error (exit 22) before any command/API call.
Added an ExUnit regression test ensuring issue list --mine errors clearly instead of being treated as an issue id.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
app/lib/linear_cli/cli.ex	Filters `result.unknown` for flag-shaped tokens and routes them through the existing `:smells_bad` error handling (exit 22).
app/test/linear_cli/cli_test.exs	Adds regression coverage for the `issue list --mine` case to ensure a clear, user-facing error.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

🤖 I have created a release *beep* *boop* --- ## [0.3.0](v0.2.1...v0.3.0) (2026-08-09) ### ⚠ BREAKING CHANGES * add Readme/LICENSE, feat: wire up the issue list --project picker ([#12](#12)) ### Features * **api:** add LinearCli.Api GraphQL client (Phase 1) ([723f3f6](723f3f6)) * **cli:** add issue create/develop/pr/take/update write commands (Phase 6) ([1649618](1649618)) * **cli:** support Ruby's short subcommand aliases ([#15](#15)) ([9fca6b5](9fca6b5)) * initial commit with ash submodule ([c2ceafb](c2ceafb)) * **linear:** add Ash domain resources for Issue/Project/Team/User/Label/WorkflowState/Comment (Phase 2) ([e2a27f3](e2a27f3)) * **oban:** add scheduled monthly project rollover (Phase 7) ([11afb43](11afb43)) * phase 4 from initial plan -> complete ([012866e](012866e)) * phase 8 - packaging, releasing, and CI ([#1](#1)) ([905c238](905c238)) * scaffold Elixir port and enforce conventional commits ([a4d03a0](a4d03a0)) ### Bug Fixes * **ci:** create releases as drafts so assets survive Immutable Releases ([#19](#19)) ([8572623](8572623)) * **cli:** reject unrecognized flags instead of treating them as issue ids ([#2](#2)) ([#4](#4)) ([e697ff6](e697ff6)) ### Performance Improvements * **linear:** fan out find-by-ids and per-team project fetches (Phase 5) ([fb00153](fb00153)) ### Documentation * add Readme/LICENSE, feat: wire up the issue list --project picker ([#12](#12)) ([eb42c69](eb42c69)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [0.4.0](v0.3.1...v0.4.0) (2026-08-09) ### ⚠ BREAKING CHANGES * add Readme/LICENSE, feat: wire up the issue list --project picker ([#12](#12)) ### Features * **api:** add LinearCli.Api GraphQL client (Phase 1) ([723f3f6](723f3f6)) * **cli:** add issue create/develop/pr/take/update write commands (Phase 6) ([1649618](1649618)) * **cli:** support Ruby's short subcommand aliases ([#15](#15)) ([9fca6b5](9fca6b5)) * initial commit with ash submodule ([c2ceafb](c2ceafb)) * **linear:** add Ash domain resources for Issue/Project/Team/User/Label/WorkflowState/Comment (Phase 2) ([e2a27f3](e2a27f3)) * **oban:** add scheduled monthly project rollover (Phase 7) ([11afb43](11afb43)) * phase 4 from initial plan -> complete ([012866e](012866e)) * phase 8 - packaging, releasing, and CI ([#1](#1)) ([905c238](905c238)) * scaffold Elixir port and enforce conventional commits ([a4d03a0](a4d03a0)) ### Bug Fixes * **ci:** create releases as drafts so assets survive Immutable Releases ([#19](#19)) ([8572623](8572623)) * **ci:** package release binaries with the wrapper scripts ([#24](#24)) ([5fb24a4](5fb24a4)) * **cli:** reject unrecognized flags instead of treating them as issue ids ([#2](#2)) ([#4](#4)) ([e697ff6](e697ff6)) ### Performance Improvements * **linear:** fan out find-by-ids and per-team project fetches (Phase 5) ([fb00153](fb00153)) ### Documentation * add Readme/LICENSE, feat: wire up the issue list --project picker ([#12](#12)) ([eb42c69](eb42c69)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [0.5.0](v0.4.0...v0.5.0) (2026-08-09) ### ⚠ BREAKING CHANGES * add Readme/LICENSE, feat: wire up the issue list --project picker ([#12](#12)) ### Features * **api:** add LinearCli.Api GraphQL client (Phase 1) ([723f3f6](723f3f6)) * **cli:** add issue create/develop/pr/take/update write commands (Phase 6) ([1649618](1649618)) * **cli:** support Ruby's short subcommand aliases ([#15](#15)) ([9fca6b5](9fca6b5)) * initial commit with ash submodule ([c2ceafb](c2ceafb)) * **linear:** add Ash domain resources for Issue/Project/Team/User/Label/WorkflowState/Comment (Phase 2) ([e2a27f3](e2a27f3)) * **oban:** add scheduled monthly project rollover (Phase 7) ([11afb43](11afb43)) * phase 4 from initial plan -> complete ([012866e](012866e)) * phase 8 - packaging, releasing, and CI ([#1](#1)) ([905c238](905c238)) * scaffold Elixir port and enforce conventional commits ([a4d03a0](a4d03a0)) ### Bug Fixes * **ci:** create releases as drafts so assets survive Immutable Releases ([#19](#19)) ([8572623](8572623)) * **ci:** package release binaries with the wrapper scripts ([#24](#24)) ([5fb24a4](5fb24a4)) * **cli:** reject unrecognized flags instead of treating them as issue ids ([#2](#2)) ([#4](#4)) ([e697ff6](e697ff6)) ### Performance Improvements * **linear:** fan out find-by-ids and per-team project fetches (Phase 5) ([fb00153](fb00153)) ### Documentation * add Readme/LICENSE, feat: wire up the issue list --project picker ([#12](#12)) ([eb42c69](eb42c69)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [0.6.0](v0.5.0...v0.6.0) (2026-08-09) ### ⚠ BREAKING CHANGES * add Readme/LICENSE, feat: wire up the issue list --project picker ([#12](#12)) ### Features * **api:** add LinearCli.Api GraphQL client (Phase 1) ([723f3f6](723f3f6)) * **cli:** add issue create/develop/pr/take/update write commands (Phase 6) ([1649618](1649618)) * **cli:** support Ruby's short subcommand aliases ([#15](#15)) ([9fca6b5](9fca6b5)) * initial commit with ash submodule ([c2ceafb](c2ceafb)) * **linear:** add Ash domain resources for Issue/Project/Team/User/Label/WorkflowState/Comment (Phase 2) ([e2a27f3](e2a27f3)) * **oban:** add scheduled monthly project rollover (Phase 7) ([11afb43](11afb43)) * phase 4 from initial plan -> complete ([012866e](012866e)) * phase 8 - packaging, releasing, and CI ([#1](#1)) ([905c238](905c238)) * scaffold Elixir port and enforce conventional commits ([a4d03a0](a4d03a0)) ### Bug Fixes * **ci:** create releases as drafts so assets survive Immutable Releases ([#19](#19)) ([8572623](8572623)) * **ci:** package release binaries with the wrapper scripts ([#24](#24)) ([5fb24a4](5fb24a4)) * **cli:** reject unrecognized flags instead of treating them as issue ids ([#2](#2)) ([#4](#4)) ([e697ff6](e697ff6)) ### Performance Improvements * **linear:** fan out find-by-ids and per-team project fetches (Phase 5) ([fb00153](fb00153)) ### Documentation * add Readme/LICENSE, feat: wire up the issue list --project picker ([#12](#12)) ([eb42c69](eb42c69)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [0.7.0](v0.6.0...v0.7.0) (2026-08-09) ### ⚠ BREAKING CHANGES * add Readme/LICENSE, feat: wire up the issue list --project picker ([#12](#12)) ### Features * **api:** add LinearCli.Api GraphQL client (Phase 1) ([723f3f6](723f3f6)) * **cli:** add issue create/develop/pr/take/update write commands (Phase 6) ([1649618](1649618)) * **cli:** support Ruby's short subcommand aliases ([#15](#15)) ([9fca6b5](9fca6b5)) * initial commit with ash submodule ([c2ceafb](c2ceafb)) * **linear:** add Ash domain resources for Issue/Project/Team/User/Label/WorkflowState/Comment (Phase 2) ([e2a27f3](e2a27f3)) * **oban:** add scheduled monthly project rollover (Phase 7) ([11afb43](11afb43)) * phase 4 from initial plan -> complete ([012866e](012866e)) * phase 8 - packaging, releasing, and CI ([#1](#1)) ([905c238](905c238)) * scaffold Elixir port and enforce conventional commits ([a4d03a0](a4d03a0)) ### Bug Fixes * **ci:** create releases as drafts so assets survive Immutable Releases ([#19](#19)) ([8572623](8572623)) * **ci:** package release binaries with the wrapper scripts ([#24](#24)) ([5fb24a4](5fb24a4)) * **cli:** reject unrecognized flags instead of treating them as issue ids ([#2](#2)) ([#4](#4)) ([e697ff6](e697ff6)) ### Performance Improvements * **linear:** fan out find-by-ids and per-team project fetches (Phase 5) ([fb00153](fb00153)) ### Documentation * add Readme/LICENSE, feat: wire up the issue list --project picker ([#12](#12)) ([eb42c69](eb42c69)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [1.0.0](v1.0.0...v1.0.0) (2026-08-11) ### ⚠ BREAKING CHANGES * graduate to 1.0.0 - disable pre-major version bumping ([#70](#70)) * **cd:** parallelize Burrito target builds and fix Trivy/Podman image scanning ([#68](#68)) * **ci:** rename release.yaml to main.yaml, workflow name to "main" ([#38](#38)) * add Readme/LICENSE, feat: wire up the issue list --project picker ([#12](#12)) ### Features * add mix githooks.install to activate the repo's git hooks ([#51](#51)) ([9b35472](9b35472)) * **api:** add LinearCli.Api GraphQL client (Phase 1) ([723f3f6](723f3f6)) * **ci:** add a full SBOM - app deps, OTP/Elixir runtime, container OS packages ([#54](#54)) ([e296fdd](e296fdd)) * **cli:** add favorite teams/projects, filtering list views by them ([#61](#61)) ([6c858d9](6c858d9)) * **cli:** add issue create/develop/pr/take/update write commands (Phase 6) ([1649618](1649618)) * **cli:** add profiles - default team/project stored in local SQLite ([#57](#57)) ([554e336](554e336)) * **cli:** add project update - post a status update to a project ([#43](#43)) ([30dc6dc](30dc6dc)) * **cli:** make version respect --output json ([#33](#33)) ([b160aad](b160aad)) * **cli:** resolve bare issue numbers via active profile, favorited teams, or a team prompt ([#65](#65)) ([8b183da](8b183da)) * **cli:** support Ruby's short subcommand aliases ([#15](#15)) ([9fca6b5](9fca6b5)) * initial commit with ash submodule ([c2ceafb](c2ceafb)) * **linear:** add Ash domain resources for Issue/Project/Team/User/Label/WorkflowState/Comment (Phase 2) ([e2a27f3](e2a27f3)) * **oban:** add scheduled monthly project rollover (Phase 7) ([11afb43](11afb43)) * phase 4 from initial plan -> complete ([012866e](012866e)) * phase 8 - packaging, releasing, and CI ([#1](#1)) ([905c238](905c238)) * scaffold Elixir port and enforce conventional commits ([a4d03a0](a4d03a0)) ### Bug Fixes * **ci:** consolidate the release pipeline into one workflow/DAG ([ba821bb](ba821bb)) * **ci:** create releases as drafts so assets survive Immutable Releases ([#19](#19)) ([8572623](8572623)) * **ci:** package release binaries with the wrapper scripts ([#24](#24)) ([5fb24a4](5fb24a4)) * **ci:** rebuild the release pipeline to stop the version-bump runaway loop ([#30](#30)) ([c311fd4](c311fd4)) * **ci:** relabel the release PR as tagged after we tag it ourselves ([ab1408e](ab1408e)) * **ci:** skip commit-subject validation in the post-merge pipeline ([#41](#41)) ([3d00a85](3d00a85)) * **cli:** reject unrecognized flags instead of treating them as issue ids ([#2](#2)) ([#4](#4)) ([e697ff6](e697ff6)) * **deps:** update ash to a non-vulnerable version ([#63](#63)) ([b838e2a](b838e2a)) ### Performance Improvements * **linear:** fan out find-by-ids and per-team project fetches (Phase 5) ([fb00153](fb00153)) ### Documentation * add Readme/LICENSE, feat: wire up the issue list --project picker ([#12](#12)) ([eb42c69](eb42c69)) ### Miscellaneous Chores * **ci:** rename release.yaml to main.yaml, workflow name to "main" ([#38](#38)) ([2581a40](2581a40)) * graduate to 1.0.0 - disable pre-major version bumping ([#70](#70)) ([87a65ae](87a65ae)) ### Continuous Integration * **cd:** parallelize Burrito target builds and fix Trivy/Podman image scanning ([#68](#68)) ([5cc829a](5cc829a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Copilot AI lite review requested due to automatic review settings August 8, 2026 15:31

Copilot started reviewing on behalf of bougyman August 8, 2026 15:31 View session

Copilot AI reviewed Aug 8, 2026

View reviewed changes

bougyman merged commit e697ff6 into main Aug 8, 2026
3 checks passed

bougyman deleted the issue-2 branch August 8, 2026 16:55

This was referenced Aug 8, 2026

chore(main): release 0.1.1 #3

Closed

chore(main): release 0.1.1 #7

Merged

chore(main): release 0.1.2 #8

Merged

chore(main): release 0.3.0 #21

Merged

This was referenced Aug 9, 2026

chore(main): release 0.3.1 #22

Merged

chore(main): release 0.4.0 #25

Merged

ruby-automation mentioned this pull request Aug 9, 2026

chore(main): release 0.5.0 #26

Merged

ruby-automation mentioned this pull request Aug 9, 2026

chore(main): release 0.6.0 #27

Merged

ruby-automation mentioned this pull request Aug 9, 2026

chore(main): release 0.7.0 #28

Merged

This was referenced Aug 9, 2026

chore(main): release 0.8.0 #29

Closed

chore(main): release 2.0.0 #71

Closed

chore(main): release 1.0.0 #73

Merged

Navigation Menu

Uh oh!

fix(cli): reject unrecognized flags instead of treating them as issue ids (#2) - #4

fix(cli): reject unrecognized flags instead of treating them as issue ids (#2)#4
bougyman merged 1 commit into
mainfrom
issue-2

bougyman commented Aug 8, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

bougyman commented Aug 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants